When I click "clone content" I am taken to node/xxx/clone , which looks like a standard node edit form.

However the "view", "edit" etc tabs link to the original node, not the new not-yet-saved node.

I have found this causes confusion for content managers - they end up accidentally editing the original node, particularly with webforms.

I think these tabs should not appear on the node/xxx/clone page until the user saves the new node.

tabs don't work as expected

Thanks for an excellent module!

CommentFileSizeAuthor
#6 1960600-6.patch1.01 KBpwolanin
#4 ux_bug_view_edit-1960600-4.patch688 bytestripper54
#2 node_clone_remove_tabs-1960600-3.patch639 bytestripper54
#1 node_clone_remove_tabs-1960600-2.patch544 bytestripper54
nodequeue-tabs.png25.74 KBtripper54

Comments

tripper54’s picture

tripper54 commented
Version: 7.x-1.0-rc1 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new node_clone_remove_tabs-1960600-2.patch544 bytes

Patch attached - removes these tabs via hook_menu_local_tasks_alter.

tripper54’s picture

tripper54 commented
Issue summary: View changes
StatusFileSize
new node_clone_remove_tabs-1960600-3.patch639 bytes

Updated patch for latest dev, with a bit of disambiguation in the comments.

pwolanin’s picture

pwolanin commented
Status: Needs review » Needs work

Hmm, this is a side effect of using the same path for save-edit and prepopulate.

The patch is wrong for the save-edit case.

tripper54’s picture

tripper54 commented
Status: Needs work » Needs review
StatusFileSize
new ux_bug_view_edit-1960600-4.patch688 bytes

Good catch. Here's the updated patch.

pwolanin’s picture

pwolanin commented
Status: Needs review » Needs work

Need to supply the default for the variable like

if (variable_get('clone_method', 'prepopulate') == 'prepopulate') {
pwolanin’s picture

pwolanin commented
Title: UX bug: "view" "edit" etc tabs on node/xx/clone link to cloned node not new node » Hide the: "view" "edit" etc tabs on the node/xx/clone form since they link to the original node
Status: Needs work » Needs review
StatusFileSize
new 1960600-6.patch1.01 KB

Actually, I don't even think we need that check there, but we do need it to suppress the token in the path.

  • pwolanin committed c15abb2 on 7.x-1.x 
    Issue #1960600 by tripper54, pwolanin: Hide the: "view" "edit" etc tabs...
pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.