Hi Guys

The label for this widget is being printed inside an "<em>" tag, it shouldn't. It should print as any other form label.

Cheers

CommentFileSizeAuthor
#3 0001-Issue-1960648-by-jm.federico-mradcliffe-Change-use-o.patch967 bytesmradcliffe

Comments

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Version: 7.x-1.1 » 7.x-1.x-dev
Component: Documentation » User interface
Assigned: Unassigned » mradcliffe

Thank you fuor the bug report.

jm.federico’s picture

jm.federico commented
Title: Label is not translatable » Label using t() for printing

Change title and imprive description.

The label is being printed by passing the label to a t().
It shouldn't.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Title: Label using t() for printing » Label using t() for printing, should use check_plain()
Status: Active » Needs review
StatusFileSize
new 0001-Issue-1960648-by-jm.federico-mradcliffe-Change-use-o.patch967 bytes

It should be check_plain($instance['label']), which is essentially the same thing, but using @ instead of %.

I think changing it to check_plain($instance['label']) is appropriate.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Fixed

Pushed commit 538b368e798526e1d888e307a8ad937cd6294c8f

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Fix html tag