Current implementation does not approve already existing suggestions when a .po file upload is composed of duplicates.

This patch is aiming to do what the checkbox is suggesting, even for duplicates.

CommentFileSizeAuthor
#6 1960654-6-force_suggestion_validation.patch4.25 KBSebCorbin
#4 force_suggestion_validation-1960654-4.patch4.71 KBlaurentchardin
#1 force_suggestion_validation-1960654.patch1.92 KBlaurentchardin

Comments

laurentchardin’s picture

laurentchardin commented
Status: Active » Needs work
StatusFileSize
new force_suggestion_validation-1960654.patch1.92 KB
SebCorbin’s picture

SebCorbin commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, force_suggestion_validation-1960654.patch, failed testing.

laurentchardin’s picture

laurentchardin commented
Status: Needs work » Needs review
StatusFileSize
new force_suggestion_validation-1960654-4.patch4.71 KB

Updating test cases to match the expected behavior.
Moderator upload will enforce update, even if duplicates are found.

SebCorbin’s picture

SebCorbin commented
Category: feature » bug

I'd say it's a bug since that will make me work on it.

SebCorbin’s picture

SebCorbin commented
Status: Needs review » Fixed
StatusFileSize
new 1960654-6-force_suggestion_validation.patch4.25 KB

This works as long as suggestions are not marked as fuzzy, but we want to keep that.

I modified the condition as ($existing->is_suggestion == 1 && $force) as we don't want to re-import and re-approve every suggestion (even those marked as accepted), thus reverting the tests as before.

Committed and attributed to you ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.