GHOP #3: Drupal 6 Support (Patch)

Very nicely done! Had some patching issues with it though (line endings and a hunk failure). Make sure to create the patch correctly..... Other then that, the module works perfectly! Well done.

Works for me, too. How about a phpdoc block for hook_filter() and a tweak to the non-standard quotes around the process case?

Here's a link to the GHOP issue: http://code.google.com/p/google-highly-open-participation-drupal/issues/...

Pssst. Guys! ;) I appreciate you're trying to help, but please let the students fix the patch themselves, ok? ;)

@corsix: The patch deekayen uploaded found at least one instance where there was a case "something" instead of a case 'something'.. what you might want to do is run the module through Coder module to check for any other coding standards violations.

Thanks for your hard work! :)

Patch applies cleanly and the module works perfectly. Very nicely done!

Great job, corsix! I marked your task complete. :) Feel free to grab another if you'd like!

Steven has put this module up for adoption, and so far there have been no takers. I just gave myself commit access, review this, committed to HEAD, and created a 6.x-1.x-dev snapshot release. There should be a tarball available the next time the packaging script runs.

I'll probably make a round of official releases (something this module never had) in a few days.

Cheers,
-Derek

Derek, I just saw your post and emailed Steven requesting to be made maintainer of codefilter. I didn't see his original request on the devel list.

Your busy enough with *project; I hate to see you become the de facto maintainer of this module.

Thanks for offering to maintain this, John, yeah -- the last thing I need is another project to worry about. ;)

You now own the project node (see http://drupal.org/node/134504#comment-647213)

At this point, I did not create a DRUPAL-6--1 branch. The D6 work is in HEAD. There's really no pressing need to make a branch, in fact -- you could add the DRUPAL-6--1-0 tag directly on HEAD and no one will be the wiser. At least for now, it seems better to have fewer branches to maintain when applying patches to all maintained release series. If you want to start developing new features for this module in HEAD, you can create a DRUPAL-6--1 branch at that time, edit the 6.x-1.x-dev release node to move it to the new branch, and create a new "6.x-2.x-dev" release node pointing to HEAD.

Anyway, feel free to contact me if you have any questions about this stuff. We use codefilter on d.o and I use it on other sites, too, so I've got a keen interest in seeing this well-maintained. I see from your existing contributions to the issue queue that you've got the right attitudes about it, so I'm confident you'll do a great job.

Thanks!
-Derek