Add State Error - Strict warning: Only variables should be passed by reference in workflow_get_workflow_states_by_sid()

What version of PHP are you using? I do not see this on 5.3.13.

I'll see if I can try 5.4. There are many modules, including core, that have issues with 5.4.

Hmm, $sids[$sid] = array_shift(workflow_get_workflow_states($options)); looks to me like a variable is being passed. Or is it complaining that the $options array was passed into the function? If that's the case, try putting an & on it and see if the issue goes away.

function workflow_get_workflow_states_by_sid($sid, &$options = array()) {

There probably aren't that many people on 7.x-1.1 yet, others may still experience it. Are you using PHP's STRICT error level?

I'm getting this error as well running PHP 5.3.9

I had the same warning under PHP 5.4.13.
I fixed it with the following PHP change:

Change the line 1334 of workflow.module file to

$arrayVar = workflow_get_workflow_states($options);
$sids[$sid] = array_shift($arrayVar);

That is create a variable with the function return value, and use that variable instead of the function as the parameter of array_shift.
Reason of the warning http://stackoverflow.com/questions/2354609/strict-standards-only-variabl...

It's just a warning in the STRICT logging mode.

We have this pattern all over core. So simple to fix

A bit more clean-up

Committed with attribution. Thanks, Andy.

I'm on Workflow 1.1 and PHP 5.4.6 and I'm still getting this error. Do I need to update to the dev version?

Yes. Once a release is published, it can no longer be changed. That's why we show -dev releases. I'm hoping to create a 7.x-1.2 release soon.

Andrey, thx for the #11, I made the same fix.