The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.After toggling Quick Edit a couple of times, the HTML fills up with redundant divs (and classes).
Shouldn't the divs be deleted after turning the edit mode off?
| Comment | File | Size | Author |
|---|---|---|---|
| redundant HTML | 91.25 KB | dmsmidt |
Comments
Comment #1
wim leersYes, they should be; or rather: it should be created only once. This is likely also a bug in D8 core then. Thanks!
Comment #2
wim leersI think this was not one of recent alphas, but a fairly old version, because I cannot reproduce this. Not in Chrome nor in Firefox (where this screenshot was made AFAICT). I know this was a bug at some point, but it's long been solved.
If you can still reproduce it, please reopen this issue and include a screencast to reproduce it on alpha 9.
Thanks!
Comment #3
dmsmidtIt's not an alpha, but it's also not old. I'm running the latest git version, branch 7.x.1.x.
I tested it in alpha 9 as well. For the completeness my modules:
$ drush pm-list --type=module --status=enabled
Package Name Version
Core Block (block) 7.22
Core Color (color) 7.22
Core Comment (comment) 7.22
Core Contextual links (contextual) 7.22
Core Dashboard (dashboard) 7.22
Core Database logging (dblog) 7.22
Core Field (field) 7.22
Core Field SQL storage (field_sql_storage) 7.22
Core Field UI (field_ui) 7.22
Core File (file) 7.22
Core Filter (filter) 7.22
Core Help (help) 7.22
Core Image (image) 7.22
Core List (list) 7.22
Core Menu (menu) 7.22
Core Node (node) 7.22
Core Number (number) 7.22
Core Options (options) 7.22
Core Overlay (overlay) 7.22
Core Path (path) 7.22
Core RDF (rdf) 7.22
Core Search (search) 7.22
Core Shortcut (shortcut) 7.22
Core System (system) 7.22
Core Taxonomy (taxonomy) 7.22
Core Text (text) 7.22
Core Toolbar (toolbar) 7.22
Core Update manager (update) 7.22
Core User (user) 7.22
Other Entity API (entity) 7.x-1.0
Spark Edit (edit) 7.x-1.0-alpha9
I made a very short screencast in both Firefox and Chrome on a Mac.
Link: http://www.screencast.com/t/Ay4wlKGo
(Let me know when viewed, would like to delete it)
Comment #4
wim leersD'oh, STUPID!
I thought you meant "toggling the editing of a particular field", but you really meant "toggling edit mode" (which is what you said, I just interpreted it in a moronic way).
Reproduced. In D7 *and* D8, sadly.
Comment #5
wim leersThis was introduced in the last big refactoring; the toolbars are now persisted for the entire duration of the in-place editing process. Previously, they were continuously created and removed upon hover/editing, which results in many more DOM operations, and is thus slower.
http://drupalcode.org/project/edit.git/commit/fb3a8b1
Comment #6
dmsmidtNo problemo :-) Good luck fixing.
I'm not (yet) ready to provide patches, too much to just dive in.
But I'm happy to test, the spark initiative has my love.
Comment #7
wim leersIf that fixes it for you, then please also RTBC #1967728-1: In-place editing toolbars in DOM not removed after stopping in-place editing, which is a port of this patch to D8. Thanks!
Comment #8
wim leersHaha, a lot of crossposting here! Looking forward to your feedback! :)
Comment #9
dmsmidtWoops, didn't ment to change the title or status. You changed the status while I was replying, so after sending the reply the status was reverted.
However, after my git pull everythings works as expected! Great fix/cleanup.
Comment #10
wim leers#9: Great! Can you then please also RTBC #1967728-1: In-place editing toolbars in DOM not removed after stopping in-place editing? :)