[D7]l2schat

welcome

As installation and usage instructions are quite important for us to review, please take a moment to make your project page follow the tips for a great project page. Also make sure your README.txt follows the guidelines for in-project documentation.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• Remove "version" from the ./l2schat.info file, it will be added by drupal.org packaging automatically.
• Remove "project" from the ./l2schat.info file, it will be added by drupal.org packaging automatically.
• Remove all old CVS $Id tags, they are not needed anymore.
  
  l2schat.php:2:// $Id$
• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).

For more see http://ventral.org/pareview/httpgitdrupalorgsandboxmudrasamey1962258git

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus, so we can get back to yours sooner..

Dear ameymudras,

Manual Review:
1. What is l2scode.txt doing in the the project folder and why is it empty?
2. Consider renaming l2schat.php to l2schat.inc
3. You don't require the slash before the filename in require_once (drupal_get_path('module', 'l2schat') . '/l2schat.php');
4. Your project doesn't seems to work, am i correct?

I understand you are keen in promoting this project. But please take some time to read Drupal Coding Standard.

I have manually checked the files and found that it doesn't follow coding standards ( code styling ). You may consider using Coder module in your local development environment to test your codes.

You can visit the following link to see the automated test report mentioned in #1.
http://ventral.org/pareview/httpgitdrupalorgsandboxmudrasamey1962258git

Make sure you fix all of them before turning the project status to Needs review again. Thank you.

Dear Amey,

I reviewd your code and found following issues.

1) All issues mentioned by D34dMan in the post #4 .
2) Instead of using txt file to store script provided by "Live 2 Support" , you should use admin configuration form.
3) There should be clear instructions for installations.
4) Use major version branches (e.g., 7.x-1.x) instead of master branches .

Thanks .

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.