Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Anonymous (not verified)
Created:
5 Apr 2013 at 19:23 UTC
Updated:
28 Jun 2018 at 19:33 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
nikhil.chavan1388 commentedHello. I would like to work for this issue.
Is there anybody who can help me in this issue fixing? Because I am a student in 'Australian National University'. I have enrolled for a a subject named 'Free and Open Source Software Development' as a part of masters course. In this course we have to be a part of an ongoing project and make a valuable contribution to that project.I decided to contribute to the documentation part of Drupal.
Hence can anybody please help me in understanding the issue and fixing this issue.
Here are my contact details,
University email id: u5202496@anu.edu.au
Personal email id: nikhil.chavan1388@gmail.com
Contact no.: +61-435845572 (available on whatsapp)
Linkedin profile: http://www.linkedin.com/pub/nikhil-chavan/3a/765/566
Comment #2
xjmHi @nikhil.chavan1388! That sounds great. The best way to get help working on Drupal issues is to join Drupal's IRC channels: http://drupal.org/irc
You can also come to core contribution mentoring twice a week in IRC, and we will help you more there: http://drupal.org/core-mentoring
Comment #2.0
xjmUpdated issue summary.
Comment #2.1
xjmRemoving myself from the author field so I can unfollow. --xjm
Comment #3
eli-tComment #4
eli-tDocumentation added in the attached.
Comment #5
dawehnerWhat a great example! Do you have more ideas for analysis we could do?
Usually we swap the checks so $view... == 'none';
Comment #6
eli-tSuggest putting further ideas in to a separate issue as discussed on IRC.
Wrt the ordering of the items in the comparison, putting the constant value first helps avoid accidental use of = rather than == so it's a habit of mine. I understand if it's too inconsistent with existing code style so here's another reroll the other way around.
Comment #7
dawehnerYeah another point is that you sort of have to keep less in mind while reading the code. Maybe this can be changed on the longrun,
but I just try to mention these kind of bits which could block the commit, so progress is made.
Comment #8
jhodgdonNot quite:
https://drupal.org/node/1354#hooks
The first line needs to be "Analyze..."
Looks good otherwise though!
Comment #9
eli-tRerolled using an imperative verb as suggested.
Comment #10
jhodgdonThanks! That looks better. :)
Comment #11
jhodgdonCommitted to 8.x. Thanks again!
Comment #12.0
(not verified) commentedfixed broken example link