I've been using nice menus and it's been working perfectly. However, its performance when using IE 6/7 is much slower than FF, rendering it basically useless. It appears that it defaults to using javascript vs. CSS in IE. It appears that it reloads the menus each time you roll over one, causing it to lag considerably (using drop-down menu style). In FF, the menus appear to be pre-loaded and pop down almost instantaneously upon roll-over. Each menu item has about 5 sub menu items and some of those sub items have 5 or so sub items.

Any thoughts on how to make this work a bit more efficiently in IE?

CommentFileSizeAuthor
#1 nice_menus.js-ie_speed.patch646 bytespcorbett

Comments

pcorbett’s picture

StatusFileSize
new646 bytes

Attached is a patch to address the slowness of the slideUp("fast") and slideDown("fast") jQuery functions used in the IEHoverPseudo function. Basically, I replaced them with show() and hide(), which shows/hides the menus instantly vs. sliding up/down, which never really worked the way I would expect it to - was not "fast" at all and didn't really "slide" at all either. So far this works with Drupal 5.3 and nice menus 5.x-1.0 well.

add1sun’s picture

Status: Active » Needs review

Yes, IE uses JS because it doesn't support CSS well enough to run the menus without it. I'm on travel right now but when I get some time this weekend I'll check it out. I am inclined to make this change since, even without performance issues, this would make the behavior the same as other browsers that aren't getting any JS "fanciness" and therefor more consistent.

Thanks for the patch.

add1sun’s picture

Status: Needs review » Fixed

I've tested this and it worked fine for me. I've not really experienced lag issues in IE so I can't say how much of an improvement there is but 1) as mentioned above I think this is an equalizing patch anyway and 2) in another thread someone mentioned using this patch and that it did improve performance for them.

this has been committed to the Drupal 5 branch and HEAD. I'd like to roll a new release of Nice Menus with this in it this weekend if possible. The only hold up is that I'd also like http://drupal.org/node/170840 to go into that release as well. So if someone can review/test that patch and give an OK, I'll get a release out ASAP.

pcorbett’s picture

Thanks for the prompt response - refreshing compared to other maintainers' response time!

bs_scorp’s picture

Thanks for the patch. This was exactly what I needed.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.