Closed (fixed)
Project:
Nice Menus
Version:
5.x-1.0
Component:
Code
Priority:
Critical
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
29 Nov 2007 at 15:34 UTC
Updated:
2 Jan 2008 at 15:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
pcorbett commentedAttached is a patch to address the slowness of the slideUp("fast") and slideDown("fast") jQuery functions used in the IEHoverPseudo function. Basically, I replaced them with show() and hide(), which shows/hides the menus instantly vs. sliding up/down, which never really worked the way I would expect it to - was not "fast" at all and didn't really "slide" at all either. So far this works with Drupal 5.3 and nice menus 5.x-1.0 well.
Comment #2
add1sun commentedYes, IE uses JS because it doesn't support CSS well enough to run the menus without it. I'm on travel right now but when I get some time this weekend I'll check it out. I am inclined to make this change since, even without performance issues, this would make the behavior the same as other browsers that aren't getting any JS "fanciness" and therefor more consistent.
Thanks for the patch.
Comment #3
add1sun commentedI've tested this and it worked fine for me. I've not really experienced lag issues in IE so I can't say how much of an improvement there is but 1) as mentioned above I think this is an equalizing patch anyway and 2) in another thread someone mentioned using this patch and that it did improve performance for them.
this has been committed to the Drupal 5 branch and HEAD. I'd like to roll a new release of Nice Menus with this in it this weekend if possible. The only hold up is that I'd also like http://drupal.org/node/170840 to go into that release as well. So if someone can review/test that patch and give an OK, I'll get a release out ASAP.
Comment #4
pcorbett commentedThanks for the prompt response - refreshing compared to other maintainers' response time!
Comment #5
bs_scorp commentedThanks for the patch. This was exactly what I needed.
Comment #6
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.