How come the Doctype is xhtml, and not "!DOCTYPE html" for html5?
Just wondering if I am missing something, or if I have to make it html5 myself, or...?

this is a real sweet theme by the way. I have wanted to use Neat for along time, and am pretty excited to find someone using it in a Drupal theme.

CommentFileSizeAuthor
#1 basic-html5-1963264-1.patch2.65 KBjoelpittet

Comments

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new basic-html5-1963264-1.patch2.65 KB

Good point, I think it's partially because of RDF. Though the other themes and d8 have opted for the html5 doctype, some have made workarounds if RDF is turned on. I tried to take the best of both world, so here's a patch.

@Stevek, just say the word and i'll commit it;)

Any questions/concerns welcome.

SteveK’s picture

SteveK commented
Status: Needs review » Closed (fixed)

Thanks. Applied the patch :)

CatherineOmega’s picture

CatherineOmega commented

Am I misreading where $language comes from in template.php? We have to declare global $language along with $user, otherwise we get this:

<html lang="" dir="" prefix="content: http://purl.org/rss/1.0/modules/content/ dc: http://purl.org/dc/terms/ foaf: http://xmlns.com/foaf/0.1/ og: http://ogp.me/ns# rdfs: http://www.w3.org/2000/01/rdf-schema# sioc: http://rdfs.org/sioc/ns# sioct: http://rdfs.org/sioc/types# skos: http://www.w3.org/2004/02/skos/core# xsd: http://www.w3.org/2001/XMLSchema#">

Patch forthcoming.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Oh yeah totally, good catch @CatherineOmega!

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue summary: View changes

put doctype html in quotes