Closed (duplicate)
Project:
Webform
Version:
7.x-4.x-dev
Component:
Documentation
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
7 Apr 2013 at 19:47 UTC
Updated:
3 Sep 2013 at 04:29 UTC
Jump to comment: Most recent file
Comments
Comment #1
barrapontoFirst attempt.
Comment #2
barrapontoAdded js behaviors for tab summaries.
Comment #3
barrapontoI suck at copy=>paste=>edit. Now it's working fine.
Comment #4
barrapontoReroll, I didn't know $form['#type'] was an object.
Comment #5
quicksketchThanks @barraponto. This is a well-written patch. The code looks good and comprehensive, but I'm mostly wondering if this is something that *should* be done. I know this will make Webform match some common conventions: e.g. Comments, Menu items, Translation etc. all place items on the content type pages. However I don't think enabling Webform on more than one content type is actually very common use-case (is it?) Most users I know just use the Webform content type that Webform comes with out of the box. Sometimes having more content types that are Webform-enabled just confuses the editorial teams.
So in short, I'm questioning if we should do this because I think it'd be increasing the visibility of a less-important option. Users hardly ever need to visit the Webform settings page, but they probably modify their content types regularly. I don't want to push up an option that people don't regularly need or use.
On the other hand... this would provide a place for us to expose the "webform_primary_node_types" variable, which right now is ONLY in code. A "primary" node type (such as the "webform" content type) has some slightly different behaviors, such as when you click "Save" on new nodes it takes you to the Webform components page instead of the front-end view version of the node.
I see where you're coming from on this request; I've just got my reservations about it.
Comment #6
barrapontoI'm not really worried about "end end users", since that interface requires a high-privileged permission. But site builders experience would benefit from following the conventions set by other modules, and as a contributor it provides a place to put some type-specific settings for webforms. For instance, search indexing could be an option in this tab.
Comment #7
hswong3i commented@barraponto: may you also give a hand on review #2062235: Split webform_node_types as content type specific.? I try to merge part of your patch into my issue.
Comment #8
hswong3i commentedMost likely this issue is now duplicated and already merged into main stream ;-)