Convert theme_views_ui_view_preview_section() to Twig

split from meta

Review for #2:

+ * - content: The content for this seciton preview.

"section"

That's all that I can see for coding style.

This issue needs manual testing steps in the issue summary and for somebody to follow the steps and test the markup.

Manual testing is also a good novice task!

Cleanup from #3 thanks @thedavidmeister and @Cottser

Ready for manual testing.

1. Added new content to site, edited front page view and inspected view preview to ensure old code was applied.
2. Applied patch from #6. Patch applied cleanly
3. Cleared caches
4. Saved theme page to ensure theme registry is cleared
5. Edited frontpage view again and confirmed that correct HTML was being applied
6. To verify added a class to preview-section in the TWIG template.
7. Cleared caches and Theme registry again
8. Confirmed additional class was added in preview (Screenshot attached)

Manual testing done as a group at Florida Drupalcamp 2013 core mentoring code sprint.

Not sure whether we want to commit a patch with a @todo in there :)

Lots of the current patches have @todo for documentation of cryptic variables, especially those in the Views conversion.

Ah I see, there is an explicit tag for @todo cleanups.

@dawehner if you know, or anybody from VDC knows just one of those @todo pieces, please let us know and we will plop them in there.

+++ b/core/modules/views/views_ui/views_ui.theme.incundefined
@@ -415,7 +415,15 @@ function theme_views_ui_style_plugin_table($variables) {
+ *   - section: @todo.

The section which is rendered (for example title, rows or pager).

+++ b/core/modules/views/views_ui/views_ui.theme.incundefined
@@ -415,7 +415,15 @@ function theme_views_ui_style_plugin_table($variables) {
+ *   - title: @todo.

The human readable title of the section.

Thanks @dawehner! Rolled them in from #14

Realized we don't need 'title', so moved the wording over to the twig file and removed that param documentation because it wasn't really a param. Tweaked the wording a bit on the first one too, I'm sure it will be changed again but hopefully that helps.

remove tags

#16 - woooah, @joelpittet looks like you didn't pull latest 8.x before you started work. There's like 500kb of regression in that last patch. Can we please get a re-roll?

Whoops, thanks @thedavidmeister. Forgot to rebase against origin/8.x

Great!

#19: 1963988-19-twig-views-ui-view-preview-section.patch queued for re-testing.

reroll plus change applied as per #23.

Working on it in PDX.

@dlu Already rerolled. :)

I think this is ready to fly. It was RTBCed by dawehner already, has been re-rolled, I re-reviewed the code and it looks good!

=> RTBC again, lets get this in.

Sadly, this patch no longer applies:

megatron:drupal dries$ git apply ../f.patch --index
error: patch failed: core/modules/views_ui/views_ui.theme.inc:474
error: core/modules/views_ui/views_ui.theme.inc: patch does not apply

I'm going to ask for a re-test to make sure.

#24: 1963988-reroll-patch19-25.patch queued for re-testing.

Rerolling.

Rerolled.

EDIT: Whoops, double post.

I think I messed this up. About to try again.

Rererolled.

For reasons I can not explain... I can not download the patch in #33 I get a page not found :( http://drupal.org/files/views_ui.1963988.33.theme_preview_section_twig_0...

Any chance of uploading again?

I also get a page not found

Re-roll from #24 the only difference is there from #33 that I guess is what @Gaelan was intending to post in #36 was the removal of the preprocess function.

#41: 1963988-41-twig-views-ui-view-preview-section.patch queued for re-testing.

I ran the test that failed locally with no errors, going to try again.

+++ b/core/modules/views_ui/templates/views-ui-view-preview-section.html.twigundefined
@@ -0,0 +1,21 @@
+ * @see template_preprocess()

Afaik we remove all of these now.

tagging

Cleanup docs from #45 and V to v.

+++ b/core/modules/views_ui/templates/views-ui-view-preview-section.html.twigundefined
@@ -0,0 +1,20 @@
+ * Default theme implementation for a iews UI preview section.

... missing v in "views" :)

Whoops, well maybe we should call them `iews` from now on:P Then it won't be confused with the concept of a view and view modes:P

Ha!

@joelpittet - I vote they should be called Iews (capital I) ;)

Committed 7d267ff and pushed to 8.x. Thanks!