Conflicting filter name.

KiberGus - November 29, 2007 - 20:27
Project:Usernode
Version:5.x-1.3
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:needs work
Description

I wanted to create a calendar view to give users convinient access to news on my site. But nodes didn't appear in the calendar, they dissappeared somewhere. Firstly I thought, that it is calendar bug, but then I've found in usernode.module on line 508 this:

      'created' => array(
        'name' => t('Usernode: Created Time'),
        'sortable' => true,
        'handler' => views_handler_field_dates(),
        'option' => 'string',
        'help' => t('Display the registration time of a user.'),
      ),

This lines define filter for views, but filter with same name already exists, usual node has one. As a result both filters are stored in array with the same key and node's filter dissappears.
As far as node is core module, I think this is usernode bug and filter name must be changed. I would suggest something like:
      'registred' => array(
        'name' => t('Usernode: Registration Time'),
        'sortable' => true,
        'handler' => views_handler_field_dates(),
        'option' => 'string',
        'help' => t('Display the registration time of a user.'),
      ),

It seems, that in my system this name is free.

#1

jpetso - November 29, 2007 - 20:46

Just wanted to mention that the correct English spelling is "registered", and it might be a good idea to namespace the filter instead of trying another (not so unlikely) name. Like, say, "usernode_created".

#2

KiberGus - November 29, 2007 - 22:22

Thanks. Spelling is not my strong side, even in my native language. Namespacing is a good idea, and, as I understand, it is not used for this names, so may be this issue should be propagated to all other modules, which use this functionality.

#3

fago - December 11, 2007 - 16:59
Status:reviewed & tested by the community» needs work

ah, I was not aware of that this is a shared namespace... Thanks for pointing that out.
So I think we should use "usernode_" as prefix.

#4

Eugef - December 25, 2008 - 13:33

This bug exists for a such long time!

In orderto make calenar views working - a have to repalce all filters and fields in usernode module from "created" to "registered".

Modified usernode 1.4 module tou can download from attach

AttachmentSize
usernode.zip 5.81 KB
 
 

Drupal is a registered trademark of Dries Buytaert.