Token context: tokens with deep more then 1 don't work [#1964434]

Comment	File	Size	Author
#7	ctools-current-page-query-token-not-returned-1964434-7.patch	743 bytes	rafaqz
#4	ctools-current-page-query-not-returned-1964434-4.patch	815 bytes	rafaqz
	panel_export_current_page_bug.txt	8.13 KB	rafaqz

Comment #1

merlinofchaos commented 8 April 2013 at 14:11

Are you sure this is really the -dev version: There are problems in 7.x-1.2 with chained tokens, but those are all fixed in the latest release, to my knowledge.

Log in or register to post comments

Comment #2

rafaqz commented 8 April 2013 at 22:13

Title:

current-page:x tokens not working

» current-page:query:x token not working

I double checked some typos and its actually only happening in current-page:query:x, I've done a few tests replacing the token in custom content and it dosn't seem to work anywhere.

it is the current dev, but it seems to be a different problem as the other tokens are all working, maybe a tokens issue?

Log in or register to post comments

Comment #3

rafaqz commented 8 April 2013 at 22:42

an example to illustrate the problem:

I put this substitution token somewhere substitutions are checked (in text, titles, cache cid etc...)

%token:current-page:query:foo

the page is loaded with a query string of ?foo=bar

But the substitution leaves no text, when it should return "bar"

Thats how it seems it should work from this test at least

Log in or register to post comments

Comment #4

rafaqz commented 21 April 2013 at 14:09

Status:

Active

» Patch (to be ported)

Status	File	Size
new	ctools-current-page-query-not-returned-1964434-4.patch	815 bytes

ctools_context_token_convert wasn't returning anything for tokens with three or more parts, here's a patch.

Log in or register to post comments

Comment #5

rafaqz commented 23 April 2013 at 08:14

Status:

Patch (to be ported)

» Needs review

Log in or register to post comments

Comment #6

23 April 2013 at 08:17

Status:

Needs review

» Needs work

The last submitted patch, ctools-current-page-query-not-returned-1964434-4.patch, failed testing.

Log in or register to post comments

Status	File	Size
new	ctools-current-page-query-token-not-returned-1964434-7.patch	743 bytes

Comment #8

merlinofchaos commented 23 April 2013 at 17:27

Is it possible to get a token into there that won't explode correctly leaving parts[0] undefined and causing a notice error?

Log in or register to post comments

Comment #9

rafaqz commented 24 April 2013 at 02:44

probably not, its copied from the validation in the token module.

token.module:651: $parts = explode(':', $token, 2);

token.module:653: if (!isset($token_info['tokens'][$type][$parts[0]])) {

Log in or register to post comments

Comment #10

moonray commented 7 June 2013 at 11:20

Status:

Needs review

» Reviewed & tested by the community

The patch in #7 fixes the issue. Haven't noticed any errors/notices so far.

Log in or register to post comments

Comment #11

kalabro

she/her

commented 17 June 2013 at 17:28

The problem in current 7.x-1.x-dev code is that Ctools tries to check something like this query:foo instead of just query.

So #7 fixes problem and looks good.

Log in or register to post comments

Comment #12

kalabro

she/her

commented 18 June 2013 at 08:14

Title:

current-page:query:x token not working

» Token context: tokens with deep more then 1 don't work

Update title to clarify problem.

Tokens like:

%token:current-page:query:foo
%token:site:current-user:mail

aren't replaced by Token context. Patch from #7 fixes it.

Log in or register to post comments

Comment #13

johnennew commented 24 June 2013 at 15:37

Confirm the patch in #7 fixes a bug when using path_breadcrumbs module and trying to access the current og_context via the site token:

%token:site:og-context--node:title
%token:site:og-context--node:url

Many thanks!

Log in or register to post comments

Comment #14

podarok

🇺🇦 he/him/his

Ukrainian

Ukraine

commented 10 July 2013 at 14:57

Assigned:

Unassigned

» merlinofchaos

#7 simple fix
RTBC

Log in or register to post comments

It works for me when accessing %token:current-page:query:xyz in a pane title, thanks! I wonder why the if (isset($tokens['tokens'][$real_type][$parts[0]])) { part is there at all. Does it hurt for the code to be a bit more optimistic and hand over everything to token_generate() without a check?

Log in or register to post comments

Comment #16

rafaqz commented 17 July 2013 at 06:09

I was also wondering if we could just delete those lines as well, just left it in to be safe assuming someone had validation there for a reason. But token runs exactly the same validation immediately after this runs so its not really needed.