Problem/Motivation

Varies issues in shortcut schema.

Proposed resolution

1. Fix schema to support all shortcut. i.e. changing shortcut.set.defult to shortcut.set.*
2. Add additional fields in active config to schema - missing links and status

Remaining tasks

#1 is fixed as part of #1964254: Configuration schemas missing langcode and uuid at places need to fix #2.

CommentFileSizeAuthor
#14 1964588-shortcut-config-schema-14.patch571 bytesvijaycs85
#14 1964588-diff-13-14.txt497 bytesvijaycs85
#14 1964588-14.png22.88 KBvijaycs85
#13 1964588-shortcut-config-schema-13.patch571 bytesvijaycs85
#10 1964588-shortcut-config-schema-9.patch1.82 KBvijaycs85
#7 1964588-3.png5.77 KBvijaycs85
#6 1964588-shortcut-config-schema-5.patch639 bytesvijaycs85
#2 1964588-shortcut-config-schema-2.patch870 bytesvijaycs85
#2 1964588-diff-1-2.txt494 bytesvijaycs85
#1 1964588-shortcut-config-schema-1.patch866 bytesvijaycs85

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Active » Needs review
StatusFileSize
new 1964588-shortcut-config-schema-1.patch866 bytes

Fixing #2 here... #3 seems needs some code re-factoring which I will confirm with @alexpott or @Gabor before start.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
StatusFileSize
new 1964588-diff-1-2.txt494 bytes
new 1964588-shortcut-config-schema-2.patch870 bytes

minor issue in schema file.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Postponed
Issue tags: +sprint

Let's have this postponed on #1964254: Configuration schemas missing langcode and uuid at places, since that is RTBC and heavily overlaps with this.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Postponed » Needs review
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

Above patch should not apply anymore due to #1964254: Configuration schemas missing langcode and uuid at places committed.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Needs review
StatusFileSize
new 1964588-shortcut-config-schema-5.patch639 bytes

Re-rolling...

vijaycs85’s picture

vijaycs85
Location London, UK
commented
StatusFileSize
new 1964588-3.png5.77 KB

Adding screenshot for issue #3 in summary.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work 
+++ b/core/modules/shortcut/config/schema/shortcut.schema.ymlundefined
@@ -16,3 +16,15 @@ shortcut.set.*:
     langcode:
       type: string
       label: 'Default language'
...
+    langcode:
+      type: string

Langcode is already there?! #1964254: Configuration schemas missing langcode and uuid at places already added langcode. Not status, but langcode it did :)

vijaycs85’s picture

vijaycs85
Location London, UK
commented

Thanks @Gábor Hojtsy. Removed duplicate langcode and added changes for #3 in summary. Links will be saved as array now.

id: content-author
uuid: d248406d-ad5c-4da8-b98e-75b8026a4285
label: 'Content author'
links:
  - 867177af-3542-4ea5-9923-f75dbcbaf081
  - ee575e60-9d75-4637-8785-03c6b854bec2
  - 35fdd99d-b405-43dd-8f3e-7f65853024bb
status: '1'
langcode: en

UPDATE: locally throwing some error on adding new shortcut set. This needs more work...

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Needs review
StatusFileSize
new 1964588-shortcut-config-schema-9.patch1.82 KB

Attaching patch for #9 :)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Do we *need* to modify the format here so we can write a schema for it, or is just a choice we can make?

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

In other words, I'd avoid modifying the format if at all possible and just document it in this issue.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes

Updated issue summary.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
StatusFileSize
new 1964588-shortcut-config-schema-13.patch571 bytes

Moving the format problem as a separate issue #1971456: Make usage of shortcut.settings.links consistent. This change doesn't affect schema, so this issue is not blocked :)

vijaycs85’s picture

vijaycs85
Location London, UK
commented
StatusFileSize
new 1964588-14.png22.88 KB
new 1964588-diff-13-14.txt497 bytes
new 1964588-shortcut-config-schema-14.patch571 bytes

Attaching inspector form with minor label fix.

1964588-14.png

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Looks like all good, thanks.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Quick fix, -Configuration system, -D8MI, -sprint, -language-config, -Configuration schema

The last submitted patch, 1964588-shortcut-config-schema-14.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Needs review

#14: 1964588-shortcut-config-schema-14.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1964588-shortcut-config-schema-14.patch, failed testing.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs work » Needs review
Issue tags: +Quick fix, +Configuration system, +D8MI, +sprint, +language-config, +Configuration schema

#14: 1964588-shortcut-config-schema-14.patch queued for re-testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC as per #15. Test fails were unrelated.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -sprint

Superb, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated issue summary.