This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.

Problem/motivation

#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. While there are little cleanups planned for the format overall, the current format is a result of months of back and forths, so it should be perfectly fine to apply it more widely to core.

Proposed solution

Create a configuration schema for picture module.

Schema in place

Schema not yet in place
picture.schema.yml

CommentFileSizeAuthor
#1 1964592-picture-schema-1.patch989 bytesvijaycs85

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Title: Copy of Create configuration schemas for picture module » Create configuration schemas for picture module
Status: Active » Needs review
StatusFileSize
new 1964592-picture-schema-1.patch989 bytes

Updating patch...

attiks’s picture

attiks commented

Since this is pretty new to me, some comments

+++ b/core/modules/picture/config/schema/picture.schema.ymlundefined
@@ -0,0 +1,33 @@
+    status:
+      type: boolean
+      label: 'Status'

I assume status is added to all config entities?

+++ b/core/modules/picture/config/schema/picture.schema.ymlundefined
@@ -0,0 +1,33 @@
+    langcode:
+      type: string

Is the language mandatory, I can not think of a use case where we need a different mapping depending on the language.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Status is indeed a built-in part of config entities. Unless you define a custom export key list, it will be exported into .yml. See http://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Config%21E...

The language does not indicate a language variance of the mapping. It indicates the language the mapping was saved in. Since the mapping has a label (which is human facing I assume), the language of the mapping is the language of the human facing textual pieces of it. langcode is a built-in feature of all config entities. Config entities used to be saved with 'und' prior to earlier today, as of #1947814: New config entities often save as langcode: und incorrectly.

attiks’s picture

attiks commented
Status: Needs review » Reviewed & tested by the community

#3 Thanks for the clarification!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Also?

+    mappings:
+      type: sequence
+      label: 'Mappings'

Holy confusing, Batman. :)

vijaycs85’s picture

vijaycs85
Location London, UK
commented

LOL, yeah... Thank god it's not 'mapping' :)

Automatically closed -- issue fixed for 2 weeks with no activity.

eli-t’s picture

eli-t
he/him
Primary language English
Location Manchester
commented
Component: picture.module » responsive_image.module
Issue summary: View changes