This module disabled edition capability of nodes belonging to selected content types once they have been published for the first time. Nobody can edit such a node, event its creator.

This can be useful, for example, to ensure that the web version of a newsletter remains identical to the version sent.

Edition locking takes place in the edit form of each content type (in the publishing options tab) through a single checkbox. If checked, any node of this content type will not be editable anymore (unless by a user having the administrator role. Should an administrator try to edit a protected node, a message will be displayed over the edition form but edition will not be forbidden).

This is a lit bit more specific than revoking the "Content type : Edit any content" permission because the content remains fully editable until its first publication.

Link to the sandbox project page : http://drupal.org/sandbox/davoon06/1963252
Link to the Git repository : git clone --branch master davoon06@git.drupal.org:sandbox/davoon06/1963252.git edit_no_more

Comments

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxdavoon061963252git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

rlmumford’s picture

rlmumford
Primary language English
Location Manchester
commented

Hi davoon06.

This sounds like a great module and could work well with a number of the other workflow oriented modules. Have you seen Workbench or Maestro?

Automatic Review

The automatic reviewer threw up a few issues. You can see those here:
http://ventral.org/pareview/httpgitdrupalorgsandboxdavoon061963252git

Manual Review

  • I really appreciated the little example use you gave on your module page. That was really good!
  • You've still got a master branch in your repository. It's worth deleting that.
  • hook_schema_alter() implementation should be in the .module file rather than .install. You also need a docblock saying Implements hook_schema_alter().
  • In general its best to do things without editing the core tables. Would it be possible to do this with a field API field rather than adding a column to the database? Do you need $node->published at all? If you never let anyone edit a published node, how could it be set back to unpublished?
  • Tabs are two spaces, .install seems to be using 4 spaces for indentation.
  • You've got alot of blank lines after control statements (if, else, foreach etc). This is against coding standards.
  • It looks like you might have you {}'s in the wrong place in edit_no_more_form_node_form_alter. Either the indentation is out or you've got a logical error.
  • I would recommend adding a permission to 'Edit locked content' rather than always checking against the administrator role. This would ensure compatibility with other modules and install profiles that may not have an administrator role or that want a different role to be able to edit the nodes.

Hope that was helpful. Looks like a useful module.

I recommend you go for the Review bonus as well. See the comment above.

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.