When trying to recreate an existing features including more than one vocabulary, the new hook_features_pipe_COMPONENT_alter() integration throws a lot of notices and do not allow to export the terms.

CommentFileSizeAuthor
#11 uuid_features-fix_pipe-1964722-11.patch1.22 KBduaelfr
#1 uuid_features-fix_pipe-1964722-1.patch1.16 KBduaelfr
#1 uuid_features-fix_pipe_applies_on_1962782-1964722-1-do-not-test.patch1.22 KBduaelfr

Comments

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
StatusFileSize
new uuid_features-fix_pipe_applies_on_1962782-1964722-1-do-not-test.patch1.22 KB
new uuid_features-fix_pipe-1964722-1.patch1.16 KB

There are two patches fixing this issue included :

These patches are part of the #1day1patch initiative.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Active » Needs review
busla’s picture

busla commented

I get a HUNK rejection when trying to apply.

Steps:
* Download latest dev
* Download all patches
* patch < uuid_features-fix_pipe-1964722-1.patch
* patch < uuid_features-term-export-option-variable-1962782-2.patch
* patch < uuid_features-fix_pipe_applies_on_1962782-1964722-1-do-not-test.patch

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented

I think I was not clear enough.

Wether you use the first patch alone.
Wether you try the second one on top of #1962782-2: Make exporting of uuid terms along with vocabulary optional and turned off by default..

busla’s picture

busla commented

Not in the order I posted?

In this order then?

uuid_features-fix_pipe-1964722-1.patch
uuid_features-fix_pipe_applies_on_1962782-1964722-1-do-not-test.patch
uuid_features-term-export-option-variable-1962782-2.patch

busla’s picture

busla commented
Status: Needs review » Fixed

Ok, read over this again. I choose one of two possible methods.

All fixed now, thanks.

For anyone else having this issue: You might encounter a Notice: Undefined variable: replacements in uuid_tokens() (line 95 ... if you don´t have the latest dev of the uuid module (see here)

Closing as fixed.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Fixed » Reviewed & tested by the community

Take care, you are not a module maintainer so you cannot mark an issue as "Fixed" as this state is reserved for commited patches.
You may use RTBC instead to say to the maintainer that the patch is working well.

Thank you for your review.

busla’s picture

busla commented

Right, ofcourse. Thanks :-)

josefruzicka.cz’s picture

josefruzicka.cz commented

Worked for me well. Thanks.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Status: Reviewed & tested by the community » Needs work

Sorry this needs a re-roll due to #1962782: Make exporting of uuid terms along with vocabulary optional and turned off by default.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Needs work » Needs review
StatusFileSize
new uuid_features-fix_pipe-1964722-11.patch1.22 KB

Rerolled !

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Status: Needs review » Fixed

Awesome - thanks for following up on this!

Committed to 7.x-dev - http://drupalcode.org/project/uuid_features.git/commit/f88f103

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.