There is no need for the current variable_set of the page title in the hook_install() implementation. Having this variable set in the hook_install can cause some problems with Features, as a feature that sets search 404 as a module dependency and also exports that variable to code will have the value immediately overridden, requiring a second features revert during deployment.

CommentFileSizeAuthor
#1 search404-1964760-1-remove-vset.patch693 bytese0ipso

Comments

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Title: Remove hook_install » Remove variable_set from hook_install
StatusFileSize
new search404-1964760-1-remove-vset.patch693 bytes

It is safe to just remove the variable_set since the default value si passed along with variable_get all times. variable_get('search404_page_title', t('Page not found'))

q0rban’s picture

q0rban commented
Title: Remove variable_set from hook_install » Remove page title variable_set from hook_install
KrisBulman’s picture

KrisBulman commented
Status: Active » Reviewed & tested by the community

I ran into this problem when strongarming vars under a feature, the title var would always get overridden by the default value set in hook_install. This patch resolved the matter.

zyxware’s picture

zyxware commented
Status: Reviewed & tested by the community » Fixed

@q0rban - Thanks for the report. @e0ipso - Thanks for the patch. The patch has been applied to the 7.x-1.x branch and should be present in the next release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updating description to match title.