At admin/structure/taxonomy, in my list of vocabulary terms, I clicked on the "Reset to alphabetical" button, it shows the following error messages:

Notice: Undefined index: #vocabulary in shs_form_taxonomy_overview_terms_submit() (line 705 of C:\........\sites\all\modules\shs\shs.module). 
Notice: Trying to get property of non-object in shs_form_taxonomy_overview_terms_submit() (line 705 of C:\........\sites\all\modules\shs\shs.module). 

It is a clean drupal 7.21 installation with Simple hierarchical select 7.16 only. I was testing out Simple hierarchical select. See attachment Shs_reorder.png for more details.

CommentFileSizeAuthor
Shs_reorder.png53.83 KBxn2001

Comments

stborchert’s picture

Version: 7.x-1.6 » 7.x-1.x-dev
Status: Active » Fixed

I've committed a fix for this so the error wouldn't come back.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

george.plescan’s picture

Issue summary: View changes

I would like to reopen this issue, because the solution seems a bit strange. Why not add a check in the form alter, before changing the form submit ?

I found a similar issue with Taxonomy access fix and proposed a different solution: https://www.drupal.org/node/2270807#comment-8944847

Thanks!

george.plescan’s picture

Status: Closed (fixed) » Needs work
stborchert’s picture

Status: Needs work » Postponed (maintainer needs more info)

@george.plescan How exactly should this look like and why do you think this (simple and working) solution is strange?

stborchert’s picture

Status: Postponed (maintainer needs more info) » Closed (fixed)

Issue cleanup