Entityreference autocomplete for users still searches by username but displays full name instead

I tested that patch and it works well. Shalt I add it to the make file ezra?

Seems worth bumping the Entityreference issue via a positive review on the patch and pinging amitaibu in IRC to see if we can get it committed first. I suggest doing that, waiting a day, and if there's no progress then adding the patch to the Commons make file.

Correction: Bumping the issue review and pinging Davereid on the Realname patch :P.

I spoke to davereid in IRC and he suggested marking the issue as RTBC so he could commit it to Realname. Then seems our work would be instead to use a specific hash of that module :).

Looks like the referenced issue has been fixed in Realname. Let's bump the version number (and possibly help rolling a new release of the Realname module) to resolve this issue in Commons :).

Attached is a patch to update the real name module to the latest commit hash which includes the fix for entity reference autocompletes.

Unfortunately, the newer code doesn't seem to fix the problem; searching by real name didn't return any results, I had to search by the user name which was then displayed as the real name. It also caused a number of other errors and suggested replacing email tokens on the status report page.

Based on the previous comment, looks like we have more work remaining than was expected. Let's push this out of the 3.6 release.

The root cause here is that Entity Reference has its own callback within the EntityReference_SelectionHandler_Generic.class

Since we want realname to just alter that query, we need to implement a query alter because there is a tag for anything 'entityreference'

The autocomplete for realname isn't at issue here and works properly. Related to this issue: #2261665: Real name changes the entity reference behavior with views

Marking needs review, I believe my latest patch #3 in #2225889: Notice: Undefined offset: 5 in _og_field_widget_replace_autocomplete_path() fixes this problem, or at least it has for me :-) Apply the patch and see if this error for event organizer still occurs.

The 3rd patch in #2261665: Real name changes the entity reference behavior with views fixes this issue. Pushed to the drupal-org.make file.