Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I assume that we are now in code cleanup phase. I use PhpStorm to find possible bugs and problems in the Drupal 8 core. Normally I will not alter code flow. If I find problems in a file, which I will not fix, but find suspicious. I'll mention it in the text here.
For changes in the PHP Documentation I use this node as guide: http://drupal.org/node/1354
Checked: tableheader.inc file.
There are a few notable things about unused variables and code in that file.
First all three use statements are used nowhere not even as Annotation.
use Drupal\Core\Database\Connection;
use Drupal\Core\Database\Query\SelectExtender;
use Drupal\Core\Database\Query\SelectInterface;
Secondly:
function tablesort_header($cell, array $header, array $ts) {
The $header is nowhere used in that function. So why keep it there? I did not touched it, but it seems ignored.
| Comment | File | Size | Author |
|---|---|---|---|
| drupal_core-doc_cleanup-tablesort.inc_.patch | 3.43 KB | ro-no-lo |
Comments
Comment #2
jhodgdonOK, after getting through about 5 patches you have done... I commend your thought of cleaning up, but we cannot have one patch for every file in the Drupal source code. These types of cleanups need to be done in conjunction with our current clean-up efforts.
Also, please don't mark patches as component "documentation" unless they are purely documentation efforts.... And documentation clean-up is being handled on:
#1310084: [meta] API documentation cleanup sprint
so please go there to help with this effort instead of making new issues. Thanks!
Comment #3
darol100 commentedThis patch does not apply anymore nor past the automatic test. In addition, this issue is been handler in another issue. For this reason, I'm closing it.