6.0 port of node_clone

There is at least one pending patch regarding $node->name - that needs to be tested and fixed first. Did you port from the 1.x or 2.x branch?

this one: http://drupal.org/node/166684

please test - especially as a non-admin user.

I just committed these patches:

http://drupal.org/node/198013
http://drupal.org/node/166684

so you may need to re-roll your patch.

also, why this change:

-function clone_node_type($op, $type_obj) {
-
+function clone_node_type($op, $info) {

I always thought $info was a very unhelpful variable name. what's being passed in is a type object

Could the Drupal 6 port be finished, committed to HEAD and then be branched to DRUPAL-6--1 as soon as possible please? I want to update DrupalBin to Drupal 6. I could rework the patch from DRUPAL-5--2 if that's required.

ok, I synched HEAD with the 5x-2 branch and then worked up the attached patch. The patch above didn't apply, but I cut, pasted and edited some useful parts of it.

Passes basic testing - I'll tag and release a 6.x beta off HEAD. Please test the committed code.

Seems to be working perfectly, nicely done! It also seems to be already committed to HEAD. Should we branch to DRUPAL-6--1 and make the development release snapshots for both DRUPAL-5 and DRUPAL-6--1?

I tagged and made a 6.x beta release. No point in branching now.

http://drupal.org/node/221051

This beta is not yet displayed on the project home. Fix this by going inside the release > Edit > Save :-)

@hass - thanks, I was wondering why it didn't show up.

This is a project module bug.

I think this patch is committed, isn't it? so marking as fixed.

yes - patch is committed - but I was still hoping for feedback on whether it works...