class views_join - "directly added string" and "numeric" option not working as advertised

Hm. With the changeover to PDO, the 'numeric' setting is probably obsolete.

I'm not sure about the raw string. Clearly that's not working, and it's possible that functionality was removed. A patch to add it in might be fine. Note that what you're doing with it is probably fairly dangerous as the table names like you have can't be guaranteed, so I'm not sure it will work in any case.

I think that for what you're trying to do, you'll probably need a custom join handler; views_join can't handle trying to put in table names, I'm afraid. Sorry about that.

Visually your patch looks right, so I don't know why the patch is failing. :( Maybe testbot is in a bad mood.

Subscribing !

I need to alter a view query to add a specific INNER JOIN with 3 conditions and there's no way to do it following the views_join doc because it doesn't work as expected !

function MY_MODULE_views_query_alter(&$view, &$query) {
  if ($view->human_name == 'photothèque' && $view->current_display == 'page_1') {
    // The join I want :
    // INNER JOIN {field_data_field_album_image_on_wall} field_data_field_album_image_on_wall ON field_data_field_album_images_coll.entity_id = field_data_field_album_image_on_wall.entity_id AND (field_data_field_album_image_on_wall.field_album_image_on_wall_value = 1 AND field_data_field_album_image_on_wall.delta = field_data_field_album_images_coll.delta)
    $join = new views_join();
    $join->type  = 'INNER';
    $join->table = 'field_data_field_album_image_on_wall';
    $join->field = 'entity_id';
    $join->left_table = 'field_data_field_album_images_coll';
    $join->left_field = 'entity_id';
    // Following is not working as expected
    $join->extra = array(
      "field_data_field_album_image_on_wall.field_album_image_on_wall_value = 1",
      "field_data_field_album_image_on_wall.delta = field_data_field_album_images_coll.delta",
    );
    // Generates this :
    // INNER JOIN {field_data_field_album_image_on_wall} field_data_field_album_image_on_wall ON field_data_field_album_images_coll.entity_id = field_data_field_album_image_on_wall.entity_id AND (field_data_field_album_image_on_wall.f = 'f'  field_data_field_album_image_on_wall.f = 'f')
    $query->add_relationship('field_data_field_album_image_on_wall', $join, 'node', null);
  }
}

As you can see in the comments, the generated join miss an "AND" between these 2 conditions and about the conditions... well... should I speak about that ??? It's not what I was expecting !

Then I tried this one :

function MY_MODULE_views_query_alter(&$view, &$query) {
  if ($view->human_name == 'photothèque' && $view->current_display == 'page_1') {
    // The join I want :
    // INNER JOIN {field_data_field_album_image_on_wall} field_data_field_album_image_on_wall ON field_data_field_album_images_coll.entity_id = field_data_field_album_image_on_wall.entity_id AND (field_data_field_album_image_on_wall.field_album_image_on_wall_value = 1 AND field_data_field_album_image_on_wall.delta = field_data_field_album_images_coll.delta)
    $join = new views_join();
    $join->type  = 'INNER';
    $join->table = 'field_data_field_album_image_on_wall';
    $join->field = 'entity_id';
    $join->left_table = 'field_data_field_album_images_coll';
    $join->left_field = 'entity_id';
    // Following is not working as expected
    $join->extra = array(
      array(
        'table' => 'field_data_field_album_image_on_wall',
        'field' => 'field_album_image_on_wall_value',
        'value' => 1,
        'numeric' => 1,
        'extra type' => 'AND',
      ),
      array(
        'table' => 'field_data_field_album_image_on_wall',
        'field' => 'delta',
        'value' => 'field_data_field_album_images_coll.delta',
        'numeric' => 1,
        'extra type' => 'AND',
      ),
    );
    // Generates this :
    // INNER JOIN {field_data_field_album_image_on_wall} field_data_field_album_image_on_wall ON field_data_field_album_images_coll.entity_id = field_data_field_album_image_on_wall.entity_id AND (field_data_field_album_image_on_wall.field_album_image_on_wall_value = '1'  field_data_field_album_image_on_wall.delta = 'field_data_field_album_images_coll.delta')
    $query->add_relationship('field_data_field_album_image_on_wall', $join, 'node', null);
  }
}

Still need an "AND" between these 2 conditions and even giving numeric = 1, there are simple quotes around the values ! That sucks !! It was almost good ><

I don't know how to achieve this... If someone has an idea, feel free to share it !
Thanks

not yet as you were saying in #27 that it wasn't working anymore... but maybe you were speaking about something else ?
I am going to try it ;)

Well there was still no AND between my two "string" conditions so I made a unique string with these 2 conditions inside and thanks to your patch I now have the query I wanted !
Congrats !

I took Mołot's idea and just extended the views_join handler in order to accommodate this functionality. That way there's no need to patch Views. Once you've added the attached to your module's "views" subdirectory, you can create a new join as suggested in this comment, only replacing

$join = new views_join();

with

$join = new mymodule_handler_join();

...and

$join->extra = array(
        array(
            'field' => 'bundle',
            'value' => 'user',
        )
    );

with

$join->extra = array('somefield = somevalue');

Hope that helps!

+++ b/includes/handlers.inc
@@ -1467,7 +1468,8 @@
+ *   - - numeric: OBSOLETE. From this version ignored. In earlier versions:
+ *       If true, the value will not be surrounded in quotes.

Oh ... this sounds like a nogo, why would you do an API change which might break other people's code.

@bdimaggio
Great suggestion!

Oops. Didn't realize that my "mymodule.views.inc" failed to upload, cause d.o doesn't accept .inc files. I've disguised it as a .patch here--to use, rename as "[module name]_handler_join.inc".