hook_uninstall is too general

I have created a patch for this so Taxonomy Menu is more specific when checking variables for deletion upon uninstalling the module. This prevents variables associated with the Taxonomy Menu Block from being deleted along with the Taxonomy Menu variables.

With the applied patch, the uninstall function is now:

/**
 * Implements hook_uninstall().
 */
function taxonomy_menu_uninstall() {

  //remove menu items
  db_delete('menu_links')->condition('module', 'taxonomy_menu', '=')->execute();

  //rebuild the menus
  variable_set('menu_rebuild_needed', TRUE);

  // Gets array of more specific variables set by Taxonomy Menu module.
  // This prevents known issue https://www.drupal.org/node/1966684
  // where uninstalling Taxonomy Menu will delete variables related
  // to the Taxonomy Menu Block module.
  $variable_suffixes = array(
    'vocab_menu',
    'vocab_parent',
    'voc_item',
    'display_num',
    'hide_empty_terms',
    'expanded',
    'rebuild',
    'path',
    'menu_end_all',
    'display_descendants',
    'voc_name',
    'sync',
  );

  // Delete variables.
  $query = db_select('variable', 'v')->fields('v')->execute();
  $variables = $query->fetchAll();
  foreach ($variables as $variable) {
    // Add check to make sure we only delete variables for Taxonomy Menu,
    // not variables for Taxonomy Menu Block.
    foreach ($variable_suffixes as $suffix) {
      $taxonomy_menu_variable_name = 'taxonomy_menu_' . $suffix;
      if (strpos($variable->name, $taxonomy_menu_variable_name) !== FALSE) {
        variable_del($variable->name);
      }
    }
  }
}

Looks great, nice catch, nice clean fix. Thank you @kbrinner

Back to NR, since it looks like we missed a few variables. New patch attached. (I also added a db_like condition to the query, hoping to save us some time in that loop during uninstall)

funny, this shouldn't affect tests. trying again.

Relaunched tests.

Now patch looks ok and tests passed.