'effects' now point to 'ui.effect', no 'effects.core' [#1966750]

With Hierarchical Select I started getting error messages like this:

GET _http://example.com/sites/all/modules/jquery_update/replace/ui/ui/jquery.effects.core.js?v=1.10.2 404 (Not Found),
Uncaught TypeError: Cannot set property 'drop' of undefined

As we see, it expects to find jquery.effects.core.js file while it was renamed to just "ui.effect" in 1.10.2.

Comment	File	Size	Author
#8	jquery_update-ui-effects-renamed-1966750-8.patch	1.61 KB	queenvictoria
#8	jquery_update-ui-effects-renamed-1966750-8b.patch	2.28 KB	queenvictoria
#4	jquery_update-ui-effects-renamed-1966750-4.patch	1.24 KB	altrugon
#3	jquery_update-ui-effects-renamed-1966750-3.patch	1.25 KB	queenvictoria
#1	jquery_update-1966750-1.patch	815 bytes	OnkelTem

Comments

Status	File	Size
new	jquery_update-1966750-1.patch	815 bytes

Comment #1.0

OnkelTem commented 10 April 2013 at 15:42

Issue summary:

View changes

Updated issue summary.

Comment #1.1

OnkelTem commented 10 April 2013 at 15:43

Issue summary:

View changes

Updated issue summary.

Comment #2

OnkelTem commented 10 April 2013 at 15:44

Priority:

Normal

» Major

This is actually a major.

Comment #3

queenvictoria commented 21 August 2013 at 13:07

Status	File	Size
new	jquery_update-ui-effects-renamed-1966750-3.patch	1.25 KB

As far as I can tell, all the sub effects plugins have also been renamed, around 1.9, from jquery.ui.effects-* to jquery.ui.effect-*. I've rerolled your patch with that change included as well as it solves a problem of mine (attempting to load just jquery.ui.effects-fade.min.js).

https://github.com/jquery/jquery-ui/tree/1-9-stable/ui
https://github.com/jquery/jquery-ui/tree/1-8-stable/ui

Comment #4

altrugon commented 23 August 2013 at 19:36

Status	File	Size
new	jquery_update-ui-effects-renamed-1966750-4.patch	1.24 KB

The patch proposed by queenvictoria on comment #3 renames the file to jquery.effect.core.js instead of jquery.ui.effect.js, the following patch solves this issue as OnkelTem proposed on comment #1

Comment #5

OnkelTem commented 25 August 2013 at 14:00

As far as I can tell, all the sub effects plugins have also been renamed, around 1.9, from jquery.ui.effects-* to jquery.ui.effect-*.

Good finding!
I wonder why this is being fixed only now, like nobody uses modern jQuery.

Comment #6

das-peter commented 28 August 2013 at 09:00

Status:

Needs review

» Reviewed & tested by the community

Error just occurred after updating jquer_update. Patch looks good, error is gone.
I'd say RTBC.

Comment #7

axe312 commented 6 September 2013 at 10:20

Also working for me. Please add to core!

Comment #8

queenvictoria commented 9 September 2013 at 05:04

Status	File	Size
new	jquery_update-ui-effects-renamed-1966750-8b.patch	2.28 KB
new	jquery_update-ui-effects-renamed-1966750-8.patch	1.61 KB

I'm worrying about this. Wouldn't this now be a breaking change? Shouldn't we have rather mapped all the effects.* to ui.effect-* instead? Also there was a typ-oh in my patch. New idea attached. And a variant that supports the previous incantation as well.

// inspecting &$javascript gives
effects
effects.blind
effects.bounce
...

// our previous work in this patch moves rather than repoints them to:
effects -> ui.effect (repoint)
ui.effect-bounce (move)
ui.effect-blind (move)
// (although there was an existing typ-oh that we passed through on these two in particular)
...

//so instead shouldn't we do
effects -> ui.effect (repoint)
effects.blind -> ui.effect-blind (repoint)
effects.bounce -> ui.effect-bounce (repoint)
...