Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
field system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Apr 2013 at 19:42 UTC
Updated:
29 Jul 2014 at 22:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
swentel commentedComment #2
swentel commentedBetter name
Comment #3
swentel commentedTagging
Comment #4
xjmOr, @yched suggested making it explicitly a boolean, TRUE or FALSE, instead of 0 or 1.
Comment #5
yched commentedUn-postponing.
Comment #6
yched commentedComment #7
andypostAlso each Configurable has public
$statusproperty and default Enable/Disable actions that used by views only, related issue is #1965910: Remove enable/disable entity operationsChange notice http://drupal.org/node/1926376
Comment #8
xjmI still consider #1965910: Remove enable/disable entity operations a wontfix, and the status flag is also relevant to filters, blocks, etc.
Comment #9
swentel commentedComment #10
yched commentedLooks fine :-)
Comment #11
swentel commentedIf this one goes in first, #1942346: Convert Field API variables to CMI needs a re-roll.
Comment #12
andypostSuppose better to include more places
Comment #13
yched commentedEven better :-)
Comment #14
andypostAnd 2 more places
Comment #15
webchickThis looks like good clean-up.
Committed and pushed to 8.x. Thanks!
I *think* this needs a change notice?
Comment #16
yched commentedI don't think a change notice is needed, this is only improving consistency on existing code by filling actual booleans instead of "various things that are == to TRUE or FALSE" on values that are treated as booleans by the API.
But there is no API change underneath, the underlying code makes no additional checks on those values being strict booleans, and there is no intention of doing so (none of core does).
Closing for now, but feel free to correct me.
Comment #17
swentel commentedAdjusting title