Posted by CorniI on November 30, 2007 at 9:12pm
| Project: | SimpleTest |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | CorniI |
| Status: | closed (fixed) |
| Issue tags: | GHOP |
Issue Summary
Hi,
I wrote 2 tests as part of GHOP, could someone review&commit them? There are written for HEAD drupal and HEAD simpletest. The diff is attached. Tests are for story - Preview and story - Edit. Link to GHOP: http://code.google.com/p/google-highly-open-participation-drupal/issues/...
Corni
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| newtests.patch | 2.99 KB | Ignored: Check issue status. | None | None |
Comments
#1
ok the test for story_edit is incomplete, i'm sorry, today or morning i'll update the patch with an extended test
edit: and with a review against you coding standards
#2
ok the updated patch, please use this one :)
#3
OK,
I talked with chx about them in IRC, and now, the new files, just strip the .txt :)
Corni
#4
Awesome great job. I wouldn't change anything in story edit test. In story preview I would add an assertion if field forms are not empty. You can do that with either:
- assertFieldById($fieldId, $fieldValue, $msg) or
- assertFieldByName($fieldName, $fieldValue, $msg)
#5
#6
ok, the untested (i'm in school, having no XAMPP) Code, in both i removed the t()-Calls for the random text, it's totally unneeded :) I also replaced the assertWantedTexts in story_preview-test with assertFiledByName, but i'm able to test it in 3h, not earlier :(
Corni
#7
actually, I forgot to upload the files :P here are the *tested* files :P
they should be fine ;)
#8
Committed thanks CorniI for your work.
#9
Automatically closed -- issue fixed for two weeks with no activity.