Hi,
I wrote 2 tests as part of GHOP, could someone review&commit them? There are written for HEAD drupal and HEAD simpletest. The diff is attached. Tests are for story - Preview and story - Edit. Link to GHOP: http://code.google.com/p/google-highly-open-participation-drupal/issues/...
Corni

CommentFileSizeAuthor
#7 story_edit.test_.txt1.7 KBCorniI
#7 story_preview.test_.txt1.14 KBCorniI
#3 story_edit.test_.txt1.76 KBCorniI
#3 story_preview.test_.txt1.17 KBCorniI
#2 drupal2simpletests.patch3.63 KBCorniI
newtests.patch2.99 KBCorniI
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

CorniI’s picture

CorniI CreditAttribution: CorniI commented

ok the test for story_edit is incomplete, i'm sorry, today or morning i'll update the patch with an extended test
edit: and with a review against you coding standards

CorniI’s picture

CorniI CreditAttribution: CorniI commented
FileSize
drupal2simpletests.patch3.63 KB

ok the updated patch, please use this one :)

CorniI’s picture

CorniI CreditAttribution: CorniI commented
FileSize
story_preview.test_.txt1.17 KB
story_edit.test_.txt1.76 KB

OK,
I talked with chx about them in IRC, and now, the new files, just strip the .txt :)
Corni

Rok Žlender’s picture

Rok Žlender CreditAttribution: Rok Žlender commented

Awesome great job. I wouldn't change anything in story edit test. In story preview I would add an assertion if field forms are not empty. You can do that with either:
- assertFieldById($fieldId, $fieldValue, $msg) or
- assertFieldByName($fieldName, $fieldValue, $msg)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Title: GHOP: simpletest 2 new Tests » GHOP #32: simpletest 2 new Tests
Status: Needs review » Needs work
CorniI’s picture

CorniI CreditAttribution: CorniI commented

ok, the untested (i'm in school, having no XAMPP) Code, in both i removed the t()-Calls for the random text, it's totally unneeded :) I also replaced the assertWantedTexts in story_preview-test with assertFiledByName, but i'm able to test it in 3h, not earlier :(
Corni

CorniI’s picture

CorniI CreditAttribution: CorniI commented
FileSize
story_preview.test_.txt1.14 KB
story_edit.test_.txt1.7 KB

actually, I forgot to upload the files :P here are the *tested* files :P
they should be fine ;)

Rok Žlender’s picture

Rok Žlender CreditAttribution: Rok Žlender commented
Status: Needs work » Fixed

Committed thanks CorniI for your work.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.