Problem/Motivation

This one is funny.

Steps to reproduce

  1. Install 8.x Standard. Do not create any nodes.
  2. Enable the actions module.
  3. Stick the attached view in your config staging directory (after removing the .txt extension and trailing underscore, obviously).
  4. Synchronize config and import it.
  5. Visit /array_hooray.
  6. See this:
    array.png

Proposed resolution

?

Remaining tasks

?

CommentFileSizeAuthor
#15 after_patch.png5.01 KBxjm
#15 before_patch.png14.1 KBxjm
#11 1967124-11-PASS.patch2.77 KBdamiankloip
#11 1967124-11-tests-only-FAIL.patch1.78 KBdamiankloip
#10 1967124-10-PASS.patch2.77 KBdamiankloip
#10 1967124-10-tests-only-FAIL.patch829 bytesdamiankloip
#2 durpal-1967124-2.patch845 bytesdawehner
array.png20.6 KBxjm
views.view_.array_hooray.yml_.txt2.84 KBxjm

Comments

damiankloip’s picture

damiankloip commented
Status: Active » Closed (duplicate)

This is a dupe of #1960014: Empty area handlers need to be rendered for tables

dawehner’s picture

dawehner
Primary language German
commented
Status: Closed (duplicate) » Needs review
StatusFileSize
new durpal-1967124-2.patch845 bytes

Yeah this issue is indeed different for non-table views, as the empty text is rendered into the table.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue tags: +Needs tests

Looks like we need some tests here

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: -Needs tests, -VDC

#2: durpal-1967124-2.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented

#2: durpal-1967124-2.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes

Updated issue summary.

olli’s picture

olli commented
Issue summary: View changes
Issue tags: +VDC
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue tags: +Needs tests

Re-tagging.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

2: durpal-1967124-2.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2: durpal-1967124-2.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new 1967124-10-tests-only-FAIL.patch829 bytes
new 1967124-10-PASS.patch2.77 KB

Here we go, let's get this back on the road.

We only need some really basic coverage for this. I.e. look at an empty view with a bulk form, do you see the empty text.

damiankloip’s picture

damiankloip commented
StatusFileSize
new 1967124-11-tests-only-FAIL.patch1.78 KB
new 1967124-11-PASS.patch2.77 KB

Didn't include the changes to the test view in the fail patch, let's try that again!

The last submitted patch, 10: 1967124-10-tests-only-FAIL.patch, failed testing.

The last submitted patch, 10: 1967124-10-PASS.patch, failed testing.

The last submitted patch, 11: 1967124-11-tests-only-FAIL.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_patch.png14.1 KB
new after_patch.png5.01 KB

Looks perfect to me. I also tested manually (using the test view from the patch, not my original one, as it's completely out of date).

Before patch

After patch

Thanks @damiankloip!

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Novice

.

damiankloip’s picture

damiankloip commented

How is adding this tag helping us now exactly? :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

dawehner’s picture

dawehner
Primary language German
commented

How is adding this tag helping us now exactly? :)

Ups, I had opened that issue for a long time and just did not see your response.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.