Since Panopoly is now upgraded to beta2 might be time to separate the field instances from base as it is now marked as deprecated :)

http://drupal.org/node/1064472

Under the new approach, fields base definitions typically will be exported to separate features than field instances. Features containing instances of fields provided by a different feature will be dependent on that feature. When features are regenerated, it may be necessary to refactor them to manage the new dependency relationships.

Was thinking we could move all the field_base's to panopoly_core, this might have implications on people using individual modules though.

Comments

barraponto’s picture

Will probably have to deal with #1966624: Feature 7.x-2.0-beta2 defines fields in a new way, I think it might be an issue for RC3 sites upgrading to RC4.

saltednut’s picture

Category: bug » task

From my experience, the best way this gets added is by first upgrading Features. The new field instances and bases will be their own files, so you can version them into the Features they need to be a part of. Finally, remove the old features.field files manually from the newly exported Feature. Its a pretty painless process and I haven't had trouble running sites with the new configuration. It's a marked improvement architecturally and should help with the decoupling effort for making panopoly modules work without panopoly_core. However, I don't see this as a bug - using the deprecated approach is not a bug. It's probably a task, since its really just grunt work to get these up to speed.

BTW- Drupal Commons is a good reference for how this can be set up. They even go so far as to version their own 'body' field base in a feature. Not saying this is the best direction to take, but you can see how this change aids decoupling...

saltednut’s picture

Looks like work on this has already started during populists commits for #1966012: Media Module Modals Don't Look Right in WYSIWYG in panopoly_widgets.
See: http://drupalcode.org/project/panopoly_widgets.git/commit/dfcaf84

However, now that module contains an unnessecary file.

panopoly_widgets.features.field.inc is deprecated.

Attached patch removes this file.

lsolesen’s picture

dsnopek’s picture

Just a random note: We shouldn't update (drush features-update) any features until AFTER we've had a chance to review all the patches in the queue. Doing an update before that could make some patches no longer apply and I don't want to undo anyone's hard work.

dsnopek’s picture

Title: Separate fields from field instances + Features » Separate field_base from field_instance in Panopoly Widgets
Component: Code » Widgets
Issue summary: View changes

Changing title to reflect the component this is for.

dsnopek’s picture

Issue tags: +sprint

We should try to do this before the 1.0 release.

dsnopek’s picture

Status: Active » Closed (fixed)

Not entirely sure how this happened, but it looks like this was already committed sometime back in April! I'm going to open a new issue for updating all our features: #2159119: Update all features