If a field is not editable or no editor is available edit_metadata_generator() returns array('access' => FALSE) . Currently edit_metadata() doesn't check the property but simply tries to attach the editor. This will trow an error as the property doesn't exist.

This patch addresses this in D7.

CommentFileSizeAuthor
edit-access-check.patch544 bytesoxyc

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Check field edit access before inserting an editor » Check field edit access before attaching an in-place editor
Status: Active » Fixed

Thanks so much for the patch!

I turned it into a strict comparison, but other than that, this was good to go — thanks! http://drupalcode.org/project/edit.git/commit/0b187be

(Note to self: this triggered a notice.)

EDIT: FRAK! I forgot to use git attribution for this commit :( And I was planning on doing so! I got distracted, and then… Meh, sorry!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.