Error if ticker block not included on page

cardell - December 1, 2007 - 00:54
Project:Taxonomy Ticker
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:postponed (maintainer needs more info)
Description

I was getting a Firebug error from taxonomy_ticker.js that was preventing FCKeditor from coming up. I think the error was caused because the js was included as a script, but the ticker block was not assigned to the page.

The error was in initScrolling()

I changed:

    var scrollIntervall = (document.getElementById("scrollerClipper").style.zIndex) * 10 ;
    document.scrollerIntervalID = window.setInterval("doScroll()", scrollIntervall);

to
  var refScrollerClipper = document.getElementById("scrollerClipper");
  if(refScrollerClipper) {
    var scrollIntervall = (refScrollerClipper .style.zIndex) * 10 ;
    document.scrollerIntervalID = window.setInterval("doScroll()", scrollIntervall);
  }

and it fixed the error. You might want to add this to the code.

If I did something wrong that caused this error to start when it shouldn't have, let me know.

Thanks

#1

yrocq - February 9, 2008 - 19:40
Status:active» fixed

I fixed this bug in 5-0 branch by preventing javascript from being insterted when there is no ticker available. Thanks for your feedback.

#2

drupalxykon - February 9, 2008 - 21:46

the development snapshot doesnt seem to have the fix

#3

yrocq - February 10, 2008 - 17:39
Status:fixed» postponed (maintainer needs more info)

I downloaded the last snapshot and tried to use fckeditor with the ticker block not displayed. It seems to work. Maybe the development snapshot wasn't generated yet from CVS when you downloaded it. Could you download it again and tell me if there is still a problem ? Thanks.

 
 

Drupal is a registered trademark of Dries Buytaert.