[D7] Scald: Slideshare

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi pierre75.

Automated report:
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

My notes:

In your "Issue Summary" bad link "Scald module".

scald_slideshare.module

function scald_slideshare_menu() {
  $items = array();
  $items['admin/config/media/scald_slideshare'] = array(
    'title' => 'Scald Slideshare Settings and Imports',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('scald_slideshare_imports_form'),
    'access arguments' => array('administer scald slideshare'),
    'description' => 'Configure the slideshows that should be automatically imported from slideshare',
    'file' => 'scald_slideshare.admin.inc',
  );

  return $items;
}

Use in title and description t()

Good job!
Best regards!

This issue is not fixed? See http://drupal.org/node/532400

Code seems fine, no major problems found. Your constants should start with SCALD_SLIDESHARE_* though.

----
Top Shelf Modules - Enterprise modules from the community for the community.

Couple more issues found at http://ventral.org/pareview/httpgitdrupalorgsandboxpierre751967496git. In scald_slideshare.info you can only have 1 package declaration, and you don't need php = 5.x - Drupal 7 already requires 5.2.5.

You should note on your project page that this module downloads the slideshare thumbnail to the public files directory - that could be a security problem. Setting to needs work for that, otherwise this looks ready.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Git clone command : uneeded extra underscore