Enabling moderation on an entity translated node can result in incorrect urls

Using workbench moderation and the following:

1. an entity translated content type using title module top replace the node title
2. an entity translated taxonomy vocabulary using title module to replace the term name,
- create one term and translate it (myterm-english-name | myterm-french-name)
3. create a field on the node which references (via entity reference) the vocabulary in #2
4. configure pathauto to use the name of the taxonomy term in the url
5. create a node and translate it (my english title | my french title) and reference the term from #2

The end result will be the English url is fine but the French url will contain the English term name:

fr/myterm-english-name/my-french-title

Disable moderation, regenerate the alias and the result will be fine:

fr/myterm-french-name/my-french-title

What happens is that on the first node_save from the form submit pathauto works fine. Then when workbench_moderation_store calls node_save($live_revision) a second time it triggers pathauto again and this time for some reason (maybe pathauto, entity_translation?) it incorrectly gets the entity language and the path will get the term name from the default language instead of the translated one.

Whew, confusing I know. But I am thinking calling pathauto a second time is likely unnessary and so there is a fix proposed in [#1949728|1] which involves adding one line just before the node_save which tells pathauto not to run again:

1581   unset($taxonomy_index_flag[$node->nid]);
1582   $live_revision->path['pathauto'] = 0;
1583   // Save the node.
1584   node_save($live_revision);
1585 }

This one liner fixes my issue as well as the issue referenced above, and even though it is a bit of a hack it may not be a bad idea even for performance reasons unless there is a good reason to have workbench_moderation re-run pathauto. Also, I know workbench is currently being re-factored so maybe this is just an FYI that perhaps calling node_save within workbench could be avoided altogether.