Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
aggregator.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
13 Apr 2013 at 19:40 UTC
Updated:
29 Jul 2014 at 22:10 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerThere we go
Comment #2
ParisLiakos commentedCool, thanks:)
That means we can get rid of
for
$this->id?in \Drupal\aggregator\Plugin\aggregator\processor\DefaultProcessor::settingsForm()
EDIT: nvm, this is totally wrong:)
Comment #3
ParisLiakos commentedits good to go:)
Comment #4
tim.plunkettWhile we're only using them for plugins, Annotations are technically unrelated to that subsystem (yeah, seriously), and should just be in their own namespace: \Drupal\$module\Annotation
I'm not sure that this is necessary to repeat for every property. But if it is, we should probably just do
@see \Drupal\Core\Annotation\Translatableor something similar.Comment #5
dawehnerMoved the files
and opened an issue: #1969970: How to document needed @Translation on dedicated annotation classes
Comment #7
dawehnerRerolled. I guess this should work also this time.
Comment #8
dawehnerRerole.
Comment #10
dawehner#8: drupal-1969692-8.patch queued for re-testing.
Comment #11
amateescu commentedI could only find some small nitpicks here, otherwise looks great.
Missing empty line.
Extra empty line at the end of the file?
The two above apply to all new class files, not just AggregatorFetcher.
@ingroup should be below @var.
Comment #12
dawehnerThanks!
Comment #13
dawehnerOne missing newline.
Comment #14
amateescu commentedAll good now.
Comment #15
dries commentedCommitted to 8.x. Thanks.