As reported by xjm, the readmore link is not rendered anymore.

CommentFileSizeAuthor
#14 drupal-1970136-test.patch3.56 KBolli
#14 drupal-1970136-14.patch4.91 KBolli
#14 interdiff.txt2.67 KBolli
#12 drupal-1970136-12.patch5.91 KBdawehner
#1 drupal-1970136-1.patch4.5 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new drupal-1970136-1.patch4.5 KB

Let's see whether the tests are working.

Status: Needs review » Needs work
Issue tags: -VDC

The last submitted patch, drupal-1970136-1.patch, failed testing.

oresh’s picture

oresh commented
Status: Needs work » Needs review
Issue tags: +VDC

#1: drupal-1970136-1.patch queued for re-testing.

oresh’s picture

oresh commented
Status: Needs review » Reviewed & tested by the community

Before applying the patch the 'More link' in pager section:

PAGER
Use pager:Full | Paged, 10 items
More link:Yes

Was set to Yes, but no link on the bottom of the view did not appear.

After applying the patch if showed me the link with correct text and link.
The "Display 'more' link only if there is more content" also works correctly. When enabled, and displaying 1 item on a page, i get it everywhere except the last page (as intended).
Doesn't get duplicated, markup is ok. So RTBC.
Thaks.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, drupal-1970136-1.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented

Forgot to add the config file.

PHP is really odd:

      
<div class="more-link">
  <a href="/d8/test_display_more">
    custom more text  </a>
</div>

This html is read by simplexml into:

array (
  0 => 
  SimpleXMLElement::__set_state(array(
     '@attributes' => 
    array (
      'href' => '/d8/test_display_more',
    ),
  )),
)
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

#1 seems to fix the problem though I am not about the testbot failure, nor the intention behind converting some of the tests to private test functions...

thedavidmeister’s picture

thedavidmeister commented

the testbot failed because of a fatal error in a test introduced by the patch.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
Issue tags: -VDC

#1: drupal-1970136-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC

The last submitted patch, drupal-1970136-1.patch, failed testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

@dawehner #6 references you are missing a yml file for 'test_display_more' and left and not sure if the test is fully finished with the private function changes I think were done for testing?

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new drupal-1970136-12.patch5.91 KB

Right I forgot to add the file, though I have no idea why this xpath doesn't return the actual link title.
Maybe someone can help.

Status: Needs review » Needs work

The last submitted patch, drupal-1970136-12.patch, failed testing.

olli’s picture

olli commented
StatusFileSize
new interdiff.txt2.67 KB
new drupal-1970136-14.patch4.91 KB
new drupal-1970136-test.patch3.56 KB

That xpath looks good to me, but there is some spaces from views-more.tpl.php. Added trim().

olli’s picture

olli commented
Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: -VDC

The last submitted patch, drupal-1970136-14.patch, failed testing.

olli’s picture

olli commented
Status: Needs work » Needs review
Issue tags: +VDC

#14: drupal-1970136-14.patch queued for re-testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

Great work guys!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 91e164e and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.