After making direct database updates to nodes, the nodes in question are not flushed from the entity load cache.

I noticed this whilst looking for instances of this problem in general in our code base, but as I'm not actually using entity_translation_upgrade, I haven't tested my patch, or tried to establish whether this is mitigated by other circumstances. (If it is, there should probably be at least a comment to that effect alongside the database update.)

CommentFileSizeAuthor
#1 entity_translation_upgrade-flush_entity_load_cache-1970246.patch1.72 KBjweowu

Comments

jweowu’s picture

jweowu commented
Status: Active » Needs review
StatusFileSize
new entity_translation_upgrade-flush_entity_load_cache-1970246.patch1.72 KB
jweowu’s picture

jweowu commented
Issue summary: View changes

Updated issue summary.

Status: Needs review » Needs work

The last submitted patch, entity_translation_upgrade-flush_entity_load_cache-1970246.patch, failed testing.

jweowu’s picture

jweowu commented
Status: Needs work » Needs review

The testbot failed to checkout the drupal repository. I've just seen this happen on multiple patch submissions, so I'll leave it alone for now, and try a re-test later.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

The patch looks good, but why is the second change needed? It looks unrelated to the cache issue.

jweowu’s picture

jweowu commented

Both the changes in that patch are flushing specific entities from the load cache after they have been modified directly in the database. Keeping my original caveats in mind, they looked to me like (separate) instances of the same bug.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Needs review » Reviewed & tested by the community

Ah, right, I missed the second flush :)

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Updated issue summary.

  • Commit 5277787 on 7.x-1.x, factory, et-fc, revisions authored by jweowu, committed by plach: 
    Issue #1970246 by jweowu: Fixed entity_translation_upgrade() doesn't...

  • Commit 5277787 on 7.x-1.x, factory, et-fc, revisions, workbench authored by jweowu, committed by plach: 
    Issue #1970246 by jweowu: Fixed entity_translation_upgrade() doesn't...