Strict warning: Declaration of views_join_subquery::construct() should be compatible with views_join::construct($table = NULL, $left_table = NULL, $left_field = NULL, $field = NULL, $extra = Array, $type = 'LEFT', $fields = NULL) in ctools_include() (line 113 of C:\UniServer\www\sites\all\modules\ctools\ctools.module).

This warning is not detected. http://drupal.org/node/1966328#comment-7291938 patch should fail testing but it passes.

It does not change a thing, views seems to work, but it is not a clean code (not as clean as I believed it to be already) and tests say it is.

Comments

Mołot’s picture

Mołot commented

http://drupal.org/node/1966328#comment-7301264 should fail tests too - it calls constructor with more variables than constructor has. Only these patches together should generate proper, green result. And only assuming it's not test's limitation again to hide some more of my errors.