Since #1814080: Apachesolr sort block fills cache_block table without stopping has been committed, the sort block uses a custom caching.
Unfortunately the generated cache id doe not work for all multilingual settings. If you use a path prefix for language switching, everything is OK. But if you switch the language based on the domain, the cache ids are the same across different domains / languages.

The fix simply adds the current language to the cache_id.

In addition I fixed a potential warning that cache_id is not declared because it has been declared within an "if" statement.

CommentFileSizeAuthor
multilingual_sort_block.patch3.84 KBmkalkbrenner

Comments

mkalkbrenner’s picture

Priority: Major » Critical

I set this to critical because a click on a sort link takes the user to a different domain.

nick_vh’s picture

Status: Needs review » Reviewed & tested by the community

Looks good - ready to go in

pwolanin’s picture

Why are we even caching that block - it doesn't seem worth the hassle?

nick_vh’s picture

Status: Reviewed & tested by the community » Closed (duplicate)
mkalkbrenner’s picture

Status: Closed (duplicate) » Needs review

Duplicate of itself?

cspitzlay’s picture

Status: Needs review » Closed (fixed)

Block caching is now gone altogether (see #1814080: Apachesolr sort block fills cache_block table without stopping). So this patch is no longer pertinent.