Hey whenever I use an Entity Field inside of Page Manager and click the continue button nothing happens other then the form settings I have changed returning back to defaults. It looks like the submit handler is not working. I have traced this to panopoly magic as when it is disabled everything works properly.

Panopoly Magic Enabled (Not working)

Entity Field

Panopoly Magic Disabled (Working)

Entity Field

I think the logic that needs to be corrected is part of: panopoly_magic_form_ctools_entity_field_content_type_formatter_options_alter in line 733

Marking this as critical as is a pretty severe bug.

Comments

designar’s picture

I can confirm this bug.

populist’s picture

Status: Active » Needs review
StatusFileSize
new588 bytes

Thanks for the report and let's get this solved for you.

1.) I cannot replicate this bug with my current setup which is Panopoly's latest dev + Panopoly demo. I tried to create a new page manager variant for nodes and added all sorts of different fields to it (including the body field in your example).

2.) I did a deep dive and think your trouble is related to panopoly_magic_fape_submit() which does some alteration to the cache as part of panopoly_magic_form_ctools_entity_field_content_type_formatter_styles_alter(). This is going to fail if there isn't an entity present which is NOT the case when using Panelizer, but will be the case when you are doing a general Page Manager operation. I made a quick fix here (see attached patch or latest dev) which I believe resolves, but want to check with you.

Does the patch solve the issue? Otherwise, can you give me slightly more steps to replicate.

designar’s picture

Status: Needs review » Reviewed & tested by the community

It seems you've fixed the issue ;)
My usecase was changing the view mode of a rendered entity, but with the same problem.

Now it is working, good work!

populist’s picture

Status: Reviewed & tested by the community » Fixed

Good to hear! This was committed to dev previously and is now marked as fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.