Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
other
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
15 Apr 2013 at 22:24 UTC
Updated:
3 Nov 2014 at 08:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
agentrickardAnd the patch.
Comment #4
zaporylieComment #5
calebtr commentedI identified uses of utilize in comments, t() and String::format() with:
grep -R --ignore-case --exclude-dir=core/assets --exclude-dir=core/vendor utiliz *I also checked for 'utilis' as a possible misspelling.
Thanks to YesCT for in-person help at the Pacific Northwest Drupal Summit and thanks to Les_Lim for tips on refining the grep.
I manually edited the identified files and re-wrapped some lines - so this is not exactly a reroll.
Then I ran the greps again to make sure I didn't miss anything and made a visual check with git diff 8.0.x --color-words
I think this is ready for testing. I think that I found all of these, but it would be great to have some more eyes on this.
Comment #6
calebtr commentedLooks like I have some trailing whitespace, I'll work on a new patch.
Comment #7
calebtr commentedHere is a new patch without the trailing whitespace, plus the interdiff.
Comment #8
yesct commentedoops. spaces at the beginning of the line.
this will conflict with #2246647: Rename PluginBag to LazyPluginCollection
so this or that would need a reroll (which should be fine. just noting it.)
Comment #9
calebtr commentedRemoving those extra spaces, and including a new interdiff.
Comment #10
yesct commentedI read the whole thing. Looks great.
Comment #11
yesct commentedComment #12
zaporylieI have one, extremely minor notice.
According to Drupal Coding Standards "lines containing comments must wrap as close to 80 characters as possible without going over" so you should move word "use" in this code example to previous line. There is similar situation in a few other places in your patch.
And finally: RTBC +1 :)
Comment #14
zaporylieComment #15
dsayswhat commentedAt Pacific Northwest Drupal Summit - rerolling.
Comment #16
dsayswhat commentedHere's the re-roll for the patch on #1971208-9. There were conflicts due to the renaming of EntityWithPluginBagsInterface to LazyPluginCollection which have now been resolved.
Comment #17
dsayswhat commentedremoving needs reroll tag, setting to needs review.
Comment #18
dsayswhat commentedHere's an update that fixes line lengths for some comment lines in the patch. Let me know if I got the interdiff right...
Comment #19
zaporylieThis patch still needs some work.
1. Patch file extension should be .patch, not .txt
2. In #18 is new section - probably from some other patch:
This section definitely shouldn't be included in patch.
Comment #20
metzlerd commentedTrying to tackle this
Comment #21
metzlerd commentedRerolled with intertdiff from 18.
Comment #22
zaporylieIn my opinion this is ready to commit. Thanks.
Comment #23
jhodgdon+1, thanks! Not exactly only documentation. Some UI text has changed too. All looks good though!
Comment #24
alexpottCommitted e775d66 and pushed to 8.0.x. Thanks!