*Self nominated Trivial Patch of the Month*

In English, "utilize" is not a proper verb. It is a nominalization -- a noun (utility) turned into a verb. Therre is a perfectly good verb -- "use" -- to use instead.

cf. Strunk & White and your dad's grammar teacher.

Comments

agentrickard’s picture

Status: Active » Needs review
StatusFileSize
new14.45 KB

And the patch.

Status: Needs review » Needs work

The last submitted patch, 1: 1971208-drupal-utilize-is-a-crap-word.patch, failed testing.

zaporylie’s picture

Issue summary: View changes
Issue tags: +Needs reroll
calebtr’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new16.62 KB

I identified uses of utilize in comments, t() and String::format() with:

grep -R --ignore-case --exclude-dir=core/assets --exclude-dir=core/vendor utiliz *

I also checked for 'utilis' as a possible misspelling.

Thanks to YesCT for in-person help at the Pacific Northwest Drupal Summit and thanks to Les_Lim for tips on refining the grep.

I manually edited the identified files and re-wrapped some lines - so this is not exactly a reroll.

Then I ran the greps again to make sure I didn't miss anything and made a visual check with git diff 8.0.x --color-words

I think this is ready for testing. I think that I found all of these, but it would be great to have some more eyes on this.

calebtr’s picture

Status: Needs review » Needs work

Looks like I have some trailing whitespace, I'll work on a new patch.

calebtr’s picture

Status: Needs work » Needs review
StatusFileSize
new16.62 KB
new3.31 KB

Here is a new patch without the trailing whitespace, plus the interdiff.

yesct’s picture

Status: Needs review » Needs work
+++ b/core/modules/system/core.api.php
@@ -1535,13 +1535,13 @@
+ * of losing a few items is insignificant next to power of the queue being able
+ *  to keep up with writes. As described in the processing section, regardless
+ * of the queue being reliable or not, the processing code should be aware that
+ *  an item might be handed over for processing more than once (because the
+ * processing code might time out before it finishes).

oops. spaces at the beginning of the line.

this will conflict with #2246647: Rename PluginBag to LazyPluginCollection
so this or that would need a reroll (which should be fine. just noting it.)

calebtr’s picture

Status: Needs work » Needs review
StatusFileSize
new16.61 KB
new911 bytes

Removing those extra spaces, and including a new interdiff.

yesct’s picture

Status: Needs review » Reviewed & tested by the community

I read the whole thing. Looks great.

yesct’s picture

Component: other » documentation
zaporylie’s picture

I have one, extremely minor notice.

+++ b/core/modules/views/src/Plugin/views/relationship/RelationshipPluginBase.php
@@ -34,12 +34,12 @@
  *   have to be a declared base table, but if there are no tables that
...
+ *   use this base table, it won't be very effective.

According to Drupal Coding Standards "lines containing comments must wrap as close to 80 characters as possible without going over" so you should move word "use" in this code example to previous line. There is similar situation in a few other places in your patch.

And finally: RTBC +1 :)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: 1971208-change-utilize-to-use-9.patch, failed testing.

zaporylie’s picture

Issue tags: +Needs reroll
dsayswhat’s picture

At Pacific Northwest Drupal Summit - rerolling.

dsayswhat’s picture

StatusFileSize
new16.72 KB

Here's the re-roll for the patch on #1971208-9. There were conflicts due to the renaming of EntityWithPluginBagsInterface to LazyPluginCollection which have now been resolved.

dsayswhat’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll

removing needs reroll tag, setting to needs review.

dsayswhat’s picture

Here's an update that fixes line lengths for some comment lines in the patch. Let me know if I got the interdiff right...

zaporylie’s picture

Status: Needs review » Needs work

This patch still needs some work.
1. Patch file extension should be .patch, not .txt
2. In #18 is new section - probably from some other patch:

+++ b/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php
@@ -43,7 +43,7 @@
diff --git a/core/lib/Drupal/Core/Entity/EntityWithPluginBagsInterface.php b/core/lib/Drupal/Core/Entity/EntityWithPluginBagsInterface.php

diff --git a/core/lib/Drupal/Core/Entity/EntityWithPluginBagsInterface.php b/core/lib/Drupal/Core/Entity/EntityWithPluginBagsInterface.php
new file mode 100644

new file mode 100644
index 0000000..9271826

index 0000000..9271826
--- /dev/null

--- /dev/null
+++ b/core/lib/Drupal/Core/Entity/EntityWithPluginBagsInterface.php

+++ b/core/lib/Drupal/Core/Entity/EntityWithPluginBagsInterface.php
+++ b/core/lib/Drupal/Core/Entity/EntityWithPluginBagsInterface.php
@@ -0,0 +1,28 @@

@@ -0,0 +1,28 @@
+<?php
+
+/**
+ * @file
+ * Contains \Drupal\Core\Entity\EntityWithPluginBagsInterface.
+ */
+
+namespace Drupal\Core\Entity;
+
+/**
+ * Provides an interface for an object using a plugin bag.
+ *
+ * @see \Drupal\Component\Plugin\PluginBag
+ *
+ * @ingroup plugin_api
+ */
+interface EntityWithPluginBagsInterface extends EntityInterface {
+
+  /**
+   * Returns the plugin bags used by this entity.
+   *
+   * @return \Drupal\Component\Plugin\PluginBag[]
+   *   An array of plugin bags, keyed by the property name they use to store
+   *   their configuration.
+   */
+  public function getPluginBags();
+
+}

This section definitely shouldn't be included in patch.

metzlerd’s picture

Assigned: Unassigned » metzlerd

Trying to tackle this

metzlerd’s picture

Status: Needs work » Needs review
StatusFileSize
new17.67 KB

Rerolled with intertdiff from 18.

zaporylie’s picture

Assigned: metzlerd » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: +dcwroc2014

In my opinion this is ready to commit. Thanks.

jhodgdon’s picture

Component: documentation » other

+1, thanks! Not exactly only documentation. Some UI text has changed too. All looks good though!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed e775d66 and pushed to 8.0.x. Thanks!

  • alexpott committed e775d66 on 8.0.x
    Issue #1971208 by calebtr, dsayswhat, metzlerd, agentrickard: Replace "...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.