Problem/Motivation

Currently links saved as link_id: link_id (Refer screenshot below). This is related to #1928082: Make usage of book.settings:allowed_types consistent
1964588-3.png

Proposed resolution

Fix the way saving links. So saved as "- link_id".

CommentFileSizeAuthor
#12 shortcut-links.png16.16 KBheddn
#11 Selection_015.png10.33 KBtim bozeman
#10 1971456-10.patch1.6 KBswentel
#7 1971456_7.patch1.58 KBtim bozeman
#6 tada.png68.38 KBtim bozeman
#6 1971456_6.patch1.62 KBtim bozeman
#3 1971456-shortcut-link-3.patch3.74 KBdeveshpal
#1 1971456-shortcut-link-1.patch1.27 KBvijaycs85

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Active » Needs review
StatusFileSize
new 1971456-shortcut-link-1.patch1.27 KB

Issuing patch...

jair’s picture

jair commented
Issue tags: +Needs reroll
deveshpal’s picture

deveshpal commented
StatusFileSize
new 1971456-shortcut-link-3.patch3.74 KB

Rerolled the patch and attached the updated patch file..

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs review » Needs work

Hm, I think this code must have moved - the rerolled patch adds an entirely new class. Needs another look.

tim bozeman’s picture

tim bozeman commented
Assigned: Unassigned » tim bozeman

I shall try.

tim bozeman’s picture

tim bozeman commented
Assigned: tim bozeman » Unassigned
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 1971456_6.patch1.62 KB
new tada.png68.38 KB

Tada!
tada.png
I rerolled the patch from #1 because the preSave function moved from ShortcutSetStorageController.php to ShortcutSet.php

tim bozeman’s picture

tim bozeman commented
StatusFileSize
new 1971456_7.patch1.58 KB

Whoops. Removed a commented out line from #6.

tim bozeman’s picture

tim bozeman commented

Stale? Patch no longer apply's.

tim bozeman’s picture

tim bozeman commented
Status: Needs review » Needs work
swentel’s picture

swentel commented
Status: Needs work » Needs review
StatusFileSize
new 1971456-10.patch1.6 KB
tim bozeman’s picture

tim bozeman commented
StatusFileSize
new Selection_015.png10.33 KB

Patch #10 apply's and makes the links save as - 01234567890
Selection_015.png
10++

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new shortcut-links.png16.16 KB

It works.
shortcut-links.png

amateescu’s picture

amateescu commented

The 'links' property of shortcut sets is going away entirely in #2021779: Decouple shortcuts from menu links, would you mind postponing on that a bit?

vijaycs85’s picture

vijaycs85
Location London, UK
commented

I agree with @amateescu that we are fixing something that is going to be removed in nearby future. +1 to postponed or closed(won't fix).

amateescu’s picture

amateescu commented
Status: Reviewed & tested by the community » Postponed

Ok then, let's take the cautios step first, just in case that issue doesn't make it.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
Status: Postponed » Closed (works as designed)

This is now irrelevant indeed. Let's put this issue to rest.