warning: Illegal offset type in buddylist.module on line 666

I can duplicate this problem (currently with 5.x.1.0), but (so far) only when anonymous. When logged in, I don't get the error.

Can an anonymous user have buddies?

If not, shouldn't this function immediately return an empty array, rather than attempting to query the database and build a result set?

A bit of debugging reveals that something -- probably some other module -- is calling buddylist_get_buddies() and passing the $user object, not a $uid, as the first argument. A check for is_object() makes the errors go away:

function buddylist_get_buddies($uid = NULL, $key = 'uid') {
  static $buddies;
  if (!$uid) {
    global $user;
    $uid = $user->uid;
  }
  // watchdog('debug', print_r($uid,1));
  if ((!$uid) || (is_object($uid))) return NULL; // don't even try
  if (!isset($buddies[$key][$uid])) { // ... et cetera

(edited to fix fatfingered paste)

I have duplicated the error when not logged in. When logged in the error doesnt occur. It is the activity module who is calling buddylist_get_buddies() in my case and it passes indeed the user as an object.
The fix works fine.

This is my first patch. It's made with tortoise CVS and is based on the solution presented in comment #2.

I can reproduce the problem and confirm that the fix works.

@yelvington, I think you're right on. For me, activity.module calls:

<?php
$buddies = buddylist_get_buddies($account);
?>

...instead of using $account_id or $account->uid. Are you other folks using activity.module? If so let's move this to the activity.module queue.

Changing the status back to active, as the above patches the buddylist api, when the patch should likely be for the activity.module's incorrect use of the api.