Steps to repeat:

Set menu to vertical orientation

Open long submenu that drives items off the viewport bounds.

Cannot scroll past this boundary, as seen here: https://www.dropbox.com/s/bxugnrupd4cbz6m/navbar_bug.mov

CommentFileSizeAuthor
#8 navbar-mobile-dropdown-error-1.png8.7 KBsaltednut
#8 navbar-mobile-dropdown-error-2.png22.41 KBsaltednut
#7 navbar-vert-overflow.txt1.11 KBjessebeach
#6 navbar-vertical-mobile-1971902-3.png116.98 KBsaltednut
#6 navbar-vertical-non-mobile-1971902-4.png170.51 KBsaltednut
#6 navbar-vertical-scroll-1971902-6.patch495 bytessaltednut
#5 navbar-vertical-mobile-1971902-1.png125.32 KBsaltednut
#5 navbar-vertical-mobile-1971902-2.png152.66 KBsaltednut
#4 navbar-vertical-scroll-1971902-4.patch539 bytessaltednut

Comments

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented

Rolling back to alpha7 fixes this. The regression was introduced here: http://drupalcode.org/project/navbar.git/commit/e89d73d

drupalion’s picture

drupalion commented

I have a same problem in alpha10 release.

m.stenta’s picture

m.stenta
he/him
Primary language English
commented
Version: 7.x-1.0-alpha9 » 7.x-1.x-dev

Changing the version of this to 7.x-1.x-dev since it's an outstanding issue in the dev branch...

This issue seems related, but no longer applies due to the recent changes introduced with the Backbone dependency (I think): #1852164: Navbar offset not being set correctly

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Status: Active » Needs review
Issue tags: +demo_framework
StatusFileSize
new navbar-vertical-scroll-1971902-4.patch539 bytes

Seems as if .navbar .vertical > .lining needs the bottom: 0; assignment.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Status: Needs review » Needs work
StatusFileSize
new navbar-vertical-mobile-1971902-2.png152.66 KB
new navbar-vertical-mobile-1971902-1.png125.32 KB

The patch in #4 seems to work but causes the content within the .lining to disappear at mobile-sized resolutions...

navbar-vertical-mobile-1971902-1.png

navbar-vertical-mobile-1971902-2.png

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Status: Needs work » Needs review
StatusFileSize
new navbar-vertical-scroll-1971902-6.patch495 bytes
new navbar-vertical-non-mobile-1971902-4.png170.51 KB
new navbar-vertical-mobile-1971902-3.png116.98 KB

My second attempt: this patch is assigning bottom: 0; for (min-width: 28.125em) - in my tests so far, the navbar extends the page on the smaller resolutions so the bug does not affect those screens. The bottom: 0; assignment is unnecessary for fixing scrolling issues noted by @chrisyates unless the resolution is above 450px (28.125em).
navbar-vertical-mobile-1971902-3.png
navbar-vertical-non-mobile-1971902-4.png

jessebeach’s picture

jessebeach commented
StatusFileSize
new navbar-vert-overflow.txt1.11 KB

Would folks mind testing the 7.x-1.x branch? I think these changes should fix the issue.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
StatusFileSize
new navbar-mobile-dropdown-error-2.png22.41 KB
new navbar-mobile-dropdown-error-1.png8.7 KB

I can confirm that the scrolling issue is fixed using the latest dev.

However, I am also seeing issues with modules that use hook_navbar... this might be a followup issue or tracked elsewhere?

See screenshot:
mobile preview navbar error
mobile preview navbar error

m.stenta’s picture

m.stenta
he/him
Primary language English
commented

7.x-1.x dev release works great! Super great!

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Status: Needs review » Reviewed & tested by the community

Followup posted #1985730: Modules that invoke hook navbar are being rendered incorrectly. - I'd say this issue "In vertical orientation, menu cannot scroll past viewport bounds" is fixed.

jessebeach’s picture

jessebeach commented
Status: Reviewed & tested by the community » Closed (fixed)

This fix was already pushed to 7.x-1.x.

hass’s picture

hass commented
Status: Closed (fixed) » Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.