Problem

  • For text analysis, an unsure content is re-checked again, before the CAPTCHA solution is validated.

Proposed solution

  1. Check the CAPTCHA solution before re-checking the content.
CommentFileSizeAuthor
#12 mollom.unsure-captcha.12.patch11.6 KBsun
#11 mollom.complete-form.11.patch5.15 KBsun
#9 mollom.complete-form.9.patch5.04 KBsun
#8 mollom.unsure-captcha.8.patch11.98 KBsun
#7 mollom.unsure-captcha.7.patch9.89 KBsun
#5 mollom.unsure-captcha.5.patch7.83 KBsun
#3 mollom.unsure-captcha.3.patch6.37 KBsun
#1 mollom.unsure-captcha.1.patch2.69 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new mollom.unsure-captcha.1.patch2.69 KB

Status: Needs review » Needs work

The last submitted patch, mollom.unsure-captcha.1.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new mollom.unsure-captcha.3.patch6.37 KB

Status: Needs review » Needs work

The last submitted patch, mollom.unsure-captcha.3.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new mollom.unsure-captcha.5.patch7.83 KB

Status: Needs review » Needs work

The last submitted patch, mollom.unsure-captcha.5.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new mollom.unsure-captcha.7.patch9.89 KB
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new mollom.unsure-captcha.8.patch11.98 KB

Added docs.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 7.x-2.x-dev » 6.x-2.x-dev
StatusFileSize
new mollom.complete-form.9.patch5.04 KB

Committed to 7.x-2.x.

Slightly preparing 6.x-2.x to simplify backports.

Status: Needs review » Needs work

The last submitted patch, mollom.complete-form.9.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Needs review
StatusFileSize
new mollom.complete-form.11.patch5.15 KB
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new mollom.unsure-captcha.12.patch11.6 KB

Committed #11 to 6.x-2.x.

Now on to the actual backport.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 6.x-2.x-dev » 7.x-2.x-dev
Status: Needs review » Fixed
Issue tags: +Needs backport to D6

Thanks for reporting, reviewing, and testing! Committed to all 2.x branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit f298acd on 7.x-2.x, 8.x-2.x, fbajs, actions by sun: 
    - #1971992 by sun: Fixed Text analysis should validate CAPTCHA before re...

  • Commit f298acd on 7.x-2.x, 8.x-2.x, fbajs, actions by sun: 
    - #1971992 by sun: Fixed Text analysis should validate CAPTCHA before re...