Create a Drupal 7 theme
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | usability |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
| Issue tags: | GHOP |
http://code.google.com/p/google-highly-open-participation-drupal/issues/...
Using the documentation at http://drupal.org/node/171179 as a guide, create a Drupal 6 theme. You may either create a design yourself, or port over a design from an existing template.
The template must fit the following criteria:
* Must be licensed under the GPL (not LGPL, CC, or other licenses)
* Must not already have been ported to Drupal (check http://drupal.org/project/Themes)
* Must support at least 3 columns
* Must support various Drupal system settings (Mission Statement, Logo, Slogan, Footer, etc.)
Submit theme to Drupal's Theme Development group at http://groups.drupal.org/theme-development for review, and perform at least one revision based on their feedback.
#1
This task has been claimed by Ron Williams.
#2
#3
Re-opened and now claimed by christoph.hochstrasser
#4
claimed by darek3d, but I had to reopen due to multiple claim with silverstripe task #11 which is not yet finished and is claimed by darek3d.
#5
After days of suffering through a cold (which I incidentally got right after I claimed this task), I was still able to create a theme, although it's far from done. It's based off Garland's CSS, so excuse me if some things look odd and vaguely familiar. I want to polish up and improve this theme, so have at it and post any comments, constructive criticism, and the like.
#6
marking this for review
#7
Nice theme.
1.) Notice on page.tpl.php:
notice: Undefined variable: site_title in /.../sites/all/themes/alto/page.tpl.php on line 27.2.) block.tpl.php has such a small change it shouldn't even exist in the theme. All I found was a class name change. Use the existing class.
3.) Would be nice if phptemplate_comment_wrapper() wasn't used. Exposing the templates would be better. All you have to do is copy comment-wrapper.tpl.php to the theme and rename it comment-wrapper-forum.tpl.php and add your header markup in there. I know your mimicking Garland here but that was created before the big theme changes. :)
4.) I'm writing this as I'm reviewing and well.. Looks like there's a lot of Garland code. –was about to mention other issues related to that but this is a work in progress. Are you moving away from Garland or closer to it?
5.) logo.png is transparent. Plan on supporting IE6?
Asthetic/subjective notes:
6.) Not enough contrast. The dark gray text against a light blue background make it look flat and strains my eyes. Using pure black for the text or lightening the background would help.
7.) Spacing between primary and secondary links is too far apart.
8.) "Comments" header text (from comment wrapper) doesn't fill the content width in IE6/7.
9.) IE7 is completely off. See screen shot.
10.) Opera 9.25. Search text is visible on top of the image button. Makes it unreadable. See screen shot.
11.) Use of max-width makes IE6 the odd one out. Not that it really matters. :)
How about posting this to http://groups.drupal.org/theme-development as webchick originally posted. I'm sure you'll get better feedback.
#8
Here's the theme file. I'd like you to investigate a bug I encountered in IE7. Here are the steps to reproducing the bug:
At least for me (IE7, Windows XP SP2) the right sidebar always pops to the left. I hope this doesn't stop me dead in my tracks.
Oh, and before anyone complains, yes, it still contains a lot of elements from Garland.
Edit: The file disappeared...
Edit 2: As requested, I've posted a blurb to the theme development group.
#9
Will test tonight.
#10
Here I am a day later. Sorry I haven't tested sooner.
It's looking a lot better. The issues left are minor and should be easy to fix.
1.) comment-wrapper.php had a stray closing div causing the sidebar to clear.
2.) Opera search box still has part of the search submit button covered.
3.) IE6 has gaps above and below the secondary links.
4.) Looks like maintenance-page.tpl.php doesn't match the changes in page.tpl.php. Either fix or remove since it's not absolutely necessary.
5.) theme-settings.php not used. Unless you plan on getting that advanced functionality into the theme. I would remove it.
6.) You can remove phptemplate_comment_wrapper() since your using templates.
7.) lower corner images have gamma info embeded. Looks fine on Windows. Mac Safari show's the wrong color. –this is very, very minor atm. Just a fyi. Tool like PNGCrush can get rid of them.
Only marking Needs work due to #1 & #2. The rest are minor and will mark ready on next revision if the two are fixed.
#11
The improved, bugfixed, and (hopefully) good theme. Also includes yet another name change. As for browser compatibility, this theme has been tested on Safari 3, Opera 9.25, Internet Explorer 6+, Firefox 2.0+, and Internet Explorer 5.5 (!)
#12
Late-breaking edition of the theme, with no theme-settings.php.
#13
Looks good. I think it's ready.
#14
Awesome.
@ThatPerson: Do you want to apply for CVS access to the drupal cvs repo and maintain this as an official theme?
#15
All right, sure. How do you apply for CVS access?
#16
http://drupal.org/cvs-application
#17
I'm having a slight problem with this theme for lists that exceed 9 items. Using IE, when a list has more than 10 items, the leading '1' for numerical lists is semi-chopped off. See attached screenshot, or look at it live on http://corsix.org/content/ghop-review.
#18
I would add something like this into style.css:
#main ol {padding: 0 .5em;
}
Congratulations on your GHOP achievements. :)
btw, should this issue be set to fixed?
#19
I'll try and get to fixing that small glitch by tomorrow.
#20
I suggest change #d-top: #BCD2E9 color by #EFF7FF and .node: border-bottom: #E9EFF3 by #BCD2E9. I think this change will increase the legibility of the content inside node. Please consider that.
#21
#22
Marking this back to active since it was RTBC for GHOP.
#23
Related issue :
#293540: New theme to include for D7
#79023: Get an administration theme into core