Convert aggregator_admin_refresh_feed to a new style controller

This is going to fail, the main issue is that auto loading of aggregator_feed is not being triggered. Help welcome

Ok think I have got to bottom of the issues. Parameters passed into a controller need to match those defined in the route.

Yes I just worked out the parameter stuff :)

as a bonus you could try to convert it to RedirectResponse().not sure if it is supposed to work though

This is being covered in another issue and yes it might work but lets not scope creep. #1668866: Replace drupal_goto() with RedirectResponse

Updated to use interface type hinting

Yeah more wscci conversions!

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Routing/AggregatorController.phpundefined
@@ -8,8 +8,13 @@
 use Symfony\Component\DependencyInjection\ContainerInterface;
+use Symfony\Component\HttpFoundation\Request;
 use Drupal\Core\ControllerInterface;
+use Drupal\aggregator\Plugin\Core\Entity\Feed;
 use Drupal\Core\Entity\EntityManager;
+use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
+use Symfony\Component\HttpFoundation\RedirectResponse;

It would be cool to have them ordered properly.

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Routing/AggregatorController.phpundefined
@@ -24,20 +29,30 @@ class AggregatorController implements ControllerInterface {
+   * Stores the Entity manager.

I thought we store the Request :)

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Routing/AggregatorController.phpundefined
@@ -56,4 +71,23 @@ public function feedAdd() {
+   * @param \Drupal\aggregator\Plugin\Core\Entity\Feed $aggregator_feed

Please let's also use the interface in the documentation of the method.

Re-ordered Use statements and updated docs :)

Great!

Good catch!

Great stuff!

+++ b/core/modules/aggregator/lib/Drupal/aggregator/Routing/AggregatorController.phpundefined
@@ -31,6 +35,13 @@ class AggregatorController implements ControllerInterface {
+   /**
+   * Stores the current request.
+   *
+   * @var \Symfony\Component\HttpFoundation\Request
+   */
+  protected $request;

@@ -38,10 +49,13 @@ class AggregatorController implements ControllerInterface {
+  public function __construct(EntityManager $entity_manager, Connection $database, Request $request) {

Actually I realized that we don't need to store the request on the object. Controllers have the magic to pass in the request object, if specified in the controller method. Just try that out, it works. Fancy right?

Looks good

Committed 0a7825c and pushed to 8.x. Thanks!