http://code.google.com/p/google-highly-open-participation-drupal/issues/...

The Snippets section of the Drupal.org handbook is an invaluable resource
that the community uses to share code. Proper security and style reviews
are needed to make sure Drupal remains secure and stable.

Review mini-modules for Drupal 5.x in the handbook to verify that they work
as a module and they comply with code and security standards.
Correct/expand those that need it. Mark acceptable and newly corrected
ones as reviewed on x date.

This task involves setting up a local web server and selecting 4
mini-modules (see list below) to review by recreating the module and
testing locally to verify it actually works. Non-working modules will have
the page unpublished. For working mini-modules, perform a code review to
ensure the code adheres to security and code style best practices. If they
do not, make the corrections needed. Mark reviewed mini-module handbook
pages with the date of the passing review.

The deliverable on this task is to mark 4 mini-modules either as reviewed
and compliant (after a review by member of the security team) or create an
issue to have the page unpublished by a site admin.

Resources:
* Mini modules: http://drupal.org/node/126743
* See "Coding resources" section in the Wiki

Estimated time:
5 days

Comments

webchick’s picture

Status: Active » Needs review

This task has been claimed by kourge. Work is available for review at http://code.google.com/p/google-highly-open-participation-drupal/issues/...

webchick’s picture

Title: #40: Review mini-modules for compliance with style and security best practices » GHOP #40: Review mini-modules for compliance with style and security best practices
Project: Google Highly Open Participation Contest (GHOP) » Documentation
Component: GHOP Task » Customization and Theming Guide
add1sun’s picture

Status: Needs review » Fixed

Looks good kourge! I've had security team give them a look over and so I'm marking this task complete.

kourge’s picture

OMG, I feel sorry now because I've failed to notice this issue up until now.

webchick’s picture

Oh hey. Please don't feel sorry. We're still kind of learning how best to manage this program so there are a few kinks we're working out. We'll try and communicate better in the future. :)

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.