Oh, I must be hallucinating and/or be just too bright for this world! Can anyone please check the following command line input & output and tell me where the error is? Well, there is one patch failing, obviously. But this cannot be the reason for the complete lack of the folder drupal8-spark after the whole procedure, can it?

$ git clone --branch 8.x-1.x http://git.drupal.org/project/spark.git
Cloning into 'spark' ...
remote: Counting objects: 1111, done.
remote: Compressing objects: 100% (1089/1089), done.
remote: Total 1111 (delta 699), reused 0 (delta 0)
Receiving objects: 100% (1111/1111), 151.69 KiB | 116 KiB/s, done.
Resolving deltas: 100% (699/699), done.
$ ls -l
spark

$ cd spark
$ sudo drush make build-spark.make /var/www/drupal8-spark
drupal cloned from http://git.drupal.org/project/drupal.git.                       [ok]
Checked out revision e7d8f3682dcd5730844ad4a2c2b931cd279d1a59. [ok]
drupal patched with seventy-eight-overlay-restyle-14.patch.                  [ok]
drupal patched with block-sectioned-form-on-top-of-seventyeight-overlay-94.patch. [ok]
drupal patched with tabbing-1913086-22.patch.                                       [ok]
Unable to patch drupal with pencils-a11y-1913214-11.patch.                  [error]
drupal patched with mobile-preview-1741498-102.patch.                        [ok]
Generated PATCHES.txt file for drupal                                                       [ok]
spark cloned from http://git.drupal.org/project/spark.git.                          [ok]
Checked out branch 8.x-1.x.                                                                       [ok]
Found makefile: drupal-org.make

Thank you, oh Lurd!

Comments

Blooniverse’s picture

Blooniverse commented

... btw, it is not Drush's make command which is problematic. I used the old Drush version 5 before, and it did not work. Now I am using the most current Drush version 6, but it still doesn't function!!!

arosboro’s picture

arosboro commented

I'm having the same issue:

/var/www/spark$ git status
# On branch 8.x-1.x
nothing to commit (working directory clean)
/var/www/spark$ git branch -a
* 8.x-1.x
remotes/origin/7.x-1.x
remotes/origin/8.x-1.x
remotes/origin/HEAD -> origin/7.x-1.x
remotes/origin/master
/var/www/spark$ sudo drush make build-spark.make /var/www/drupal8-spark
[sudo] password for arosboro:
drupal cloned from http://git.drupal.org/project/drupal.git. [ok]
Checked out revision 56021b509e28e0516c2e617f16d6f01b620bfec1. [ok]
Unable to patch drupal with overlay-restyle-1953374-21.patch. [error]
drupal patched with block-sectioned-form-96.patch. [ok]
Unable to patch drupal with pencils-a11y-1913214-11.patch. [error]
drupal patched with mobile-preview-1741498-110.patch. [ok]
Generated PATCHES.txt file for drupal [ok]
spark cloned from http://git.drupal.org/project/spark.git. [ok]
Checked out branch 8.x-1.x. [ok]
Found makefile: drupal-org.make [ok]
/var/www/spark$ ls
build-spark.make config drupal-org-core.make drupal-org.make modules README.txt rebuild-demo.sh spark.info.yml spark.install spark.profile
/var/www/spark$ ls .. | grep spark
spark

Drush version was 5.7 so I upgraded to 5.9 and got the same thing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Category: support » bug
Priority: Normal » Major

Definitely confirming you need the latest 8.x-6.x version of Drush for this to function /at all/.

And yeah, looks like a couple of patches in the .make file are out of date:

$ drush make build-spark.make foo
drupal cloned from http://git.drupal.org/project/drupal.git.                                          [ok]
Checked out revision 56021b509e28e0516c2e617f16d6f01b620bfec1.                                        [ok]
Unable to patch drupal with overlay-restyle-1953374-21.patch.                                         [error]
drupal patched with block-sectioned-form-96.patch.                                                    [ok]
Unable to patch drupal with pencils-a11y-1913214-11.patch.                                            [error]
drupal patched with mobile-preview-1741498-110.patch.                                                 [ok]
Generated PATCHES.txt file for drupal                                                                 [ok]
spark cloned from http://git.drupal.org/project/spark.git.                                            [ok]
Checked out branch 8.x-1.x.                                                                           [ok]
date(): It is not safe to rely on the system's timezone settings. You are *required* to use the       [warning]
date.timezone setting or the date_default_timezone_set() function. In case you used any of those
methods and you are still getting this warning, you most likely misspelled the timezone identifier. We
selected 'America/Los_Angeles' for 'PDT/-7.0/DST' instead pm.drush.inc:1868
Found makefile: drupal-org.make                                                                       [ok]

You can run dursh make with --force-complete to make it create the folder despite the errors:

$ drush make build-spark.make --force-complete foo

It'd be great if someone could look into those errors and see if there are newer patches available in those issues (or if the core git commit hash just needs to be updated?) that we could reference in the .make file instead (and file a patch if so). Else, we're starting a new sprint next week so I imagine we'll get around to fixing this ourselves sometime soon. :)

arosboro’s picture

arosboro commented

Thanks for the clarification webchick. Install went smoothly other than those 2 outdated patches.

arosboro’s picture

arosboro commented
Status: Active » Closed (works as designed)

Updated the documentation at http://drupal.org/node/1741590

Blooniverse’s picture

Blooniverse commented

Danx!

About the two errors/patches from above:

  1. overlay-restyle-1953374-21.patch is the most current in the issue /node/1953374; see http://drupal.org/node/1953374#comment-7262154!
  2. pencils-a11y-1913214-11.patch is the most current in the issue /node/1913214; see http://drupal.org/node/1913214#comment-7062390!

The first patch got ignored by the test system, the second patch failed [in one test].

Blooniverse’s picture

Blooniverse commented
Status: Closed (works as designed) » Postponed (maintainer needs more info)

Both patches cannot be found on https://github.com/drupal/drupal/commits/8.x yet! So it seems to me that the necessity to include both of them in Spark's make patching process still remains/persists! Switching issue status. Okay?

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Postponed (maintainer needs more info) » Fixed

I cleaned up the 8.x distro with only the mobile preview patch applied from #1741498-113: Add a responsive preview bar to Drupal core. We are not pursuing the overlay restyle as part of Spark at the moment (the UX team is busy working on that and prior designs we implemented based on their instructions have been reworked since then). We are also not pushing for the forms redesign anymore, focusing on polish and missing features for inline editing instead.

I made alpha8 available with this setup: http://drupal.org/node/1990950

There are inline editing patches in progress which are not included in that version. We'll make sure to update the 8.x branch with those before DrupalCon Portland definitely. The 8.x version is properly downloadable from that URL and can build from drush, so closing this down. Thanks for the reports all!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.