Closed (won't fix)
Project:
Drupal core
Version:
8.2.x-dev
Component:
comment.module
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
31 Mar 2005 at 02:11 UTC
Updated:
27 Jul 2016 at 09:47 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Hybernaut commentedI'm not entirely happy with this: the links in the block point to /comment/edit/$comment-id, while you really want
to go to the comment moderation page (/comment/list/approval). Any thoughts on this?
Comment #2
forngren commentedComment #3
LAs4n commentedFeature request, moving to cvs.
Comment #4
tstoecklerBumping.
This is still a valid feature request.
Comment #5
dixon_I'd say this is very easy to fix in contrib, with a very simple View. If one would like to expose the comment approval queue better in D7 there's the Shortcut module that can be used for appropriate roles.
Comment #6
tstoecklerRe-opening, at least for as long as dashboard.module still lives in core. This is an obvious candidate for that. We enable Comment module in the Standard profile so we should provide this.
Comment #7
tstoecklerOh, and sorry for not stating that:
1. The fact that Views does something isn't really an argument. This would be a out-of-the-box/product feature.
2. On the comments page, you need to select the appropriate filters first (and I don't Shortcut handles that, though I could be wrong), and it's not as handy as directly having it as a block.
Comment #8
James_Stallings commentedComment #9
James_Stallings commentedComment #10
James_Stallings commentedComment #11
tstoecklerThat's an empty patch... :)
Comment #12
James_Stallings commentedtake 2 :)
Comment #13
bryanhirsch commentedRe-rolled by Boston Initiative. Applies cleanly at commit 718fe5d90770f36335053d6f92fc53f73ac95951.
Comment #15
andypostThis should be implemnted as a view
Comment #16
moshe weitzman commentedThis is still a good feature request, 10.5 years later.
Comment #17
kylebrowning commentedheres a patch for that.
Comment #18
kylebrowning commentedComment #20
kylebrowning commentedHmmm...
Comment #21
andypost8.1 branch is broken, temporary switch to 8.0
Comment #24
andypostComment #25
kylebrowning commentedAll of the errors seem to be saying the view is already enabled?
Comment #26
kylebrowning commentedComment #28
kylebrowning commentedHeres a picture of the view placed in a block.
Comment #30
kylebrowning commentedYeah i don't get why its failing. :/ Any insight?
Comment #31
eclipsegc commentedI suspect the conflict in names here has something to do with the test problems.
Comment #32
kylebrowning commentedrenaming file.
Comment #34
kylebrowning commentedAdds to the setup function so that tests do not fail.
Comment #35
kylebrowning commentedComment #37
moshe weitzman commentedLooks proper and useful to me.
Comment #38
xjmAs a new feature, this change is postponed until 8.1.x. More details: https://www.drupal.org/core/beta-changes
Comment #40
kylebrowning commentedNot sure how this missed 8.1.x but thats fine.
Comment #41
catchMissing a space and a full-stop.
I agree with #5 though, especially now that Views is in core. We already have the default 'archive' and 'glossary' views in core which should never have been added in the first place (it was literally forgotten to remove them from the initial views in core patch) - they mostly just take up space on admin/structure/views.
So I think we need more in the issue summary as to why we'd add this block to core. It's only useful if you 1. have comments set to moderation 2. find the block and enable it - assuming you don't have another way to get notifications.
Additionally, unless I'm mistaken, this won't only show 'pending' comments, it will also show unpublished comments since we have a single boolean status column.
Let's say you have a site where comments are not set to moderation. However you get an abusive comment on the site, and unpublish it.
Won't that comment now show in the block on every page in the site? It's not pending, you unpublished it because you don't want to see it. The only way not to have the block showing everywhere now would be 1. publish the comment (not an option) 2. Delete the comment (might not be an option) 3. Disable the block
Comment #42
catchJust applied the patch to the standard profile to do some quick testing. Comments aren't moderated.
The first screenshot is after posting a comment - it tells me there are no recent comments when there are, since the block doesn't specifically mention unapproved comments in the title anyway. Also it probably shouldn't show at all if there's nothing to approve.
The second screenshot is after unpublishing the comment I just posted.
Comment #43
catchComment #44
wim leersBut #5 says it's easy to do with Views. We now have Views in core. I think it makes sense to ship with a view like this? I think it's fine to have the "archive" and "glossary" views in core available too, because they are useful examples of what is possible. This would be another such case.
However…
This indeed sucks :(
Comment #45
Bojhan commentedI am unsure about this idea, we generally avoid creating blocks that are of no use to visitors of the website. Given that this is customisation that is only applicable to websites, who use comments - the audience of a view like this is limited.
Comment #46
dawehnerI have to agree with the points made by catch/wim/Bojhan ... its great to see that views enables us to build such blocks for editors easily. Most of the time though you want this role to just be visible for a custom role anyway, which we cannot know, so people would also have to change the view all the time. Given that the pratical use is rather limited. If people don't know yet how to use views but want this kind of functionality, they also have the recent comments view provided, which provides a similar baseline to start wtih.
I would kinda vote for: Postponed, let's create maybe a blog entry about it.
Comment #47
Bojhan commentedI think this merits enough input to conclude this postponed.
Comment #48
kylebrowning commentedWhy not just close, won't fix.
Comment #49
dawehnerI agree, postpone is a weird status here.
Comment #50
yoroy commentedJust based on reading this issue's title I came in to write something similar to what @Bojhan said. Additional arguments by @catch & @dawehner: very limited use case, not a user facing feature, crowding the blocks listing page and: it just can't be made to work well because unpublished comments will be shown as well.
So, lets just not do this.
Comment #51
webchick